Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 1731593003: Revert of Add increment install native libraries first in lookup paths (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add increment install native libraries first in lookup paths (patchset #1 id:1 of https://codereview.chromium.org/1726703002/ ) Reason for revert: Breaks incremental install for M devices. Original issue's description: > Add increment install native libraries first in lookup paths > > This fixes a subtle bug where the wrong libchromium_android_linker.so is used > when it already exists in the system library path. > > BUG=587584 > > Committed: https://crrev.com/86af989585dd6aac45d3087456ef7cafb37afa86 > Cr-Commit-Position: refs/heads/master@{#377074} TBR=hanxi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587584 Committed: https://crrev.com/95faad9065e1d9fbed34f60165d6fd51bc5f7b9d Cr-Commit-Position: refs/heads/master@{#377171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
agrieve
Created Revert of Add increment install native libraries first in lookup paths
4 years, 10 months ago (2016-02-24 01:03:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731593003/1
4 years, 10 months ago (2016-02-24 01:12:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 01:20:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/95faad9065e1d9fbed34f60165d6fd51bc5f7b9d Cr-Commit-Position: refs/heads/master@{#377171}
4 years, 10 months ago (2016-02-24 01:21:43 UTC) #5
agrieve
4 years, 10 months ago (2016-02-24 01:22:55 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1729973002/ by agrieve@chromium.org.

The reason for reverting is: fixing.

Powered by Google App Engine
This is Rietveld 408576698