blink: Rename enums and functions to not collide with chromium style.

blink: Rename enums and functions to not collide with chromium style.

This fixes collisions in:
core/css/CSSBasicShapeValues.h
core/css/CSSQuadValue.h
core/css/CSSSelector.h

R=pdr,esprehn@chromium.org
BUG=582312
Committed: https://crrev.com/695202101c6f8cc9346a1f74158b66426ac6919c
Cr-Commit-Position: refs/heads/master@{#377436}

[danakj, 2016-02-24 00:35:24]

https://codereview.chromium.org/1731583003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSSelector.h (right):

https://codereview.chromium.org/1731583003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSSelector.h:95: enum MatchType {
Please critique the choices I made in this file, they might be bad.

https://codereview.chromium.org/1731583003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSParserSelector.h (right):

https://codereview.chromium.org/1731583003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSParserSelector.h:61:
CSSSelector::PseudoType pseudoType() const { return m_selector->getPseudoType();
}
Also note I didn't rename this method since I didn't have to, should I?

[pdr., 2016-02-24 00:43:35]

LGTM

https://codereview.chromium.org/1731583003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSSelector.h (right):

https://codereview.chromium.org/1731583003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSSelector.h:95: enum MatchType {
On 2016/02/24 at 00:35:24, danakj wrote:
> Please critique the choices I made in this file, they might be bad.

The colors of these sheds is acceptable to my eyes.

https://codereview.chromium.org/1731583003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSParserSelector.h (right):

https://codereview.chromium.org/1731583003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSParserSelector.h:61:
CSSSelector::PseudoType pseudoType() const { return m_selector->getPseudoType();
}
On 2016/02/24 at 00:35:24, danakj wrote:
> Also note I didn't rename this method since I didn't have to, should I?

I don't think it's necessary.

[danakj, 2016-02-24 00:44:08]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-02-24 00:45:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731583003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731583003/1

[commit-bot: I haz the power, 2016-02-24 00:49:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 00:49:55]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2016-02-24 01:10:08]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-02-24 01:10:08]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1731583003/#ps20001
(title: "get-names-2: .")

[commit-bot: I haz the power, 2016-02-24 01:12:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731583003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731583003/20001

[danakj, 2016-02-24 01:18:42]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-02-24 01:18:43]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1731583003/#ps40001
(title: "get-names-2: .")

[commit-bot: I haz the power, 2016-02-24 01:19:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731583003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731583003/40001

[danakj, 2016-02-24 01:37:04]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-02-24 01:39:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 01:39:04]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2016-02-24 01:46:09]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-02-24 01:46:09]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1731583003/#ps60001
(title: "get-names-2: .")

[commit-bot: I haz the power, 2016-02-24 01:50:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731583003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731583003/60001

[danakj, 2016-02-24 01:58:07]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-02-24 01:58:08]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1731583003/#ps80001
(title: "get-names-2: .")

[commit-bot: I haz the power, 2016-02-24 02:00:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731583003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731583003/80001

[danakj, 2016-02-24 02:14:10]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-02-24 02:14:11]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1731583003/#ps100001
(title: "get-names-2: .")

[commit-bot: I haz the power, 2016-02-24 02:18:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731583003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731583003/100001

[commit-bot: I haz the power, 2016-02-24 02:38:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 02:38:24]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[esprehn, 2016-02-24 02:42:53]

Why are we name mangling instead of just adding Get? I dunno about the
funny TypeForSerialization swap done here.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[esprehn, 2016-02-24 02:48:32]

Why are we name mangling instead of just adding Get? I dunno about the
funny TypeForSerialization swap done here.

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[danakj, 2016-02-24 19:53:05]

On Tue, Feb 23, 2016 at 6:42 PM, Elliott Sprehn <esprehn@chromium.org>
wrote:

> Why are we name mangling instead of just adding Get? I dunno about the
> funny TypeForSerialization swap done here.
>
Just trying to avoid gets for you where I can think of a reasonable name to
avoid it. I could also stop trying to do that if u want. :)

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2016-02-24 19:53:06]

On Tue, Feb 23, 2016 at 6:42 PM, Elliott Sprehn <esprehn@chromium.org>
wrote:

> Why are we name mangling instead of just adding Get? I dunno about the
> funny TypeForSerialization swap done here.
>
Just trying to avoid gets for you where I can think of a reasonable name to
avoid it. I could also stop trying to do that if u want. :)

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[esprehn, 2016-02-24 20:00:52]

If other people are okay with the names that seems fine.

[danakj, 2016-02-24 20:45:45]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-02-24 20:45:46]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1731583003/#ps120001
(title: "get-names-2: .")

[commit-bot: I haz the power, 2016-02-24 20:49:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731583003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731583003/120001

[commit-bot: I haz the power, 2016-02-24 23:17:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 23:17:27]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[danakj, 2016-02-24 23:18:38]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-02-24 23:20:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731583003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731583003/120001

[commit-bot: I haz the power, 2016-02-25 00:29:16]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-02-25 00:30:36]

Description was changed from

==========
blink: Rename enums and functions to not collide with chromium style.

This fixes collisions in:
core/css/CSSBasicShapeValues.h
core/css/CSSQuadValue.h
core/css/CSSSelector.h

R=pdr,esprehn@chromium.org
BUG=582312
==========

to

==========
blink: Rename enums and functions to not collide with chromium style.

This fixes collisions in:
core/css/CSSBasicShapeValues.h
core/css/CSSQuadValue.h
core/css/CSSSelector.h

R=pdr,esprehn@chromium.org
BUG=582312

Committed: https://crrev.com/695202101c6f8cc9346a1f74158b66426ac6919c
Cr-Commit-Position: refs/heads/master@{#377436}
==========

[commit-bot: I haz the power, 2016-02-25 00:30:38]

Patchset 7 (id:??) landed as
https://crrev.com/695202101c6f8cc9346a1f74158b66426ac6919c
Cr-Commit-Position: refs/heads/master@{#377436}