Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1731583002: Fix SyncTest#testRename (Closed)

Created:
4 years, 10 months ago by acleung1
Modified:
4 years, 10 months ago
Reviewers:
maxbogue
CC:
chromium-reviews, tim+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix SyncTest#testRename One of the shared pref needs to be reset. BUG=585309 Committed: https://crrev.com/221f906e6f3033b715d8afb107c3f38678f24877 Cr-Commit-Position: refs/heads/master@{#377382}

Patch Set 1 #

Patch Set 2 : fix code #

Patch Set 3 : fix proguard removing method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/signin/SigninHelper.java View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 1 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
acleung1
I think this explains why the tests seems to fail every few runs.
4 years, 10 months ago (2016-02-24 00:23:37 UTC) #2
maxbogue
lgtm
4 years, 10 months ago (2016-02-24 02:12:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731583002/20001
4 years, 10 months ago (2016-02-24 04:37:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/28053)
4 years, 10 months ago (2016-02-24 06:35:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731583002/40001
4 years, 10 months ago (2016-02-24 20:21:59 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-24 21:18:58 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 21:20:08 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/221f906e6f3033b715d8afb107c3f38678f24877
Cr-Commit-Position: refs/heads/master@{#377382}

Powered by Google App Engine
This is Rietveld 408576698