Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1731543004: [builtins] Migrate a bunch of Math builtins to C++. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate a bunch of Math builtins to C++. Migrate Math.imul, Math.fround, Math.acos, Math.asin and Math.atan to C++ builtins, as these ones call into C++ anyway and so there's no need to have this extra wrapper around it. R=yangguo@chromium.org Committed: https://crrev.com/f97ed07e3ad04b6df3ed322a15dec810155c8459 Cr-Commit-Position: refs/heads/master@{#34274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -75 lines) Patch
M src/bootstrapper.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/counters.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/js/math.js View 5 chunks +1 line, -34 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +0 lines, -5 lines 0 comments Download
M src/runtime/runtime-maths.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-25 07:25:17 UTC) #1
Yang
On 2016/02/25 07:25:17, Benedikt Meurer wrote: lgtm.
4 years, 10 months ago (2016-02-25 07:31:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731543004/1
4 years, 10 months ago (2016-02-25 07:50:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 08:06:20 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 08:07:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f97ed07e3ad04b6df3ed322a15dec810155c8459
Cr-Commit-Position: refs/heads/master@{#34274}

Powered by Google App Engine
This is Rietveld 408576698