Refactored DataBuffer to use unix_hacker style methods.

media/base/data_buffer.h

Index: media/base/data_buffer.h
diff --git a/media/base/data_buffer.h b/media/base/data_buffer.h
index dc1d969a99d746e671b63b92fd719a8503c8642d..142bd0bb4b27c9b1e3f28b56c1a71ce4d6549d1a 100644
--- a/media/base/data_buffer.h
+++ b/media/base/data_buffer.h
@@ -18,7 +18,7 @@ namespace media {
 // Unlike DecoderBuffer, allocations are assumed to be allocated with the
 // default memory allocator (i.e., new uint8[]).
 //
-// NOTE: It is illegal to call any method when IsEndOfStream() is true.
+// NOTE: It is illegal to call any method when is_end_of_stream() is true.
 class MEDIA_EXPORT DataBuffer : public base::RefCountedThreadSafe<DataBuffer> {
  public:
   // Allocates buffer of size |buffer_size| >= 0.
@@ -30,31 +30,31 @@ class MEDIA_EXPORT DataBuffer : public base::RefCountedThreadSafe<DataBuffer> {
   // Create a DataBuffer whose |data_| is copied from |data|.
   //
   // |data| must not be null and |size| must be >= 0.
-  static scoped_refptr<DataBuffer> CopyFrom(const uint8* data, int size);
+  static scoped_refptr<DataBuffer> copy_from(const uint8* data, int size);

[scherkus (not reviewing), 2013/06/20 21:29:13]

ditto w/ changing too much -- this should be reverted

 
   // Create a DataBuffer indicating we've reached end of stream.
   //
-  // Calling any method other than IsEndOfStream() on the resulting buffer
+  // Calling any method other than is_end_of_stream() on the resulting buffer
   // is disallowed.
-  static scoped_refptr<DataBuffer> CreateEOSBuffer();
+  static scoped_refptr<DataBuffer> create_eos_buffer();

[scherkus (not reviewing), 2013/06/20 21:29:13]

ditto

 
-  base::TimeDelta GetTimestamp() const;
-  void SetTimestamp(const base::TimeDelta& timestamp);
+  base::TimeDelta get_timestamp() const;

[scherkus (not reviewing), 2013/06/20 21:29:13]

drop get_ prefixes from these setters

+  void set_timestamp(const base::TimeDelta& timestamp);
 
-  base::TimeDelta GetDuration() const;
-  void SetDuration(const base::TimeDelta& duration);
+  base::TimeDelta get_duration() const;
+  void set_duration(const base::TimeDelta& duration);
 
-  const uint8* GetData() const;
-  uint8* GetWritableData();
+  const uint8* get_data() const;
+  uint8* get_writable_data();
 
   // The size of valid data in bytes.
   //
   // Setting this value beyond the buffer size is disallowed.
-  int GetDataSize() const;
-  void SetDataSize(int data_size);
+  int get_data_size() const;
+  void set_data_size(int data_size);
 
   // If there's no data in this buffer, it represents end of stream.
-  bool IsEndOfStream() const;
+  bool is_end_of_stream() const;

[scherkus (not reviewing), 2013/06/20 21:29:13]

drop is_ prefix

 
  protected:
   friend class base::RefCountedThreadSafe<DataBuffer>;