runtime/vm/resolver.cc - Issue 17315008: Optimizing noSuchMethod invocation with no arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/resolver.cc

Issue 17315008: Optimizing noSuchMethod invocation with no arguments. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: addressed comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/resolver.cc

===================================================================

--- runtime/vm/resolver.cc (revision 24189)

+++ runtime/vm/resolver.cc (working copy)

@@ -138,7 +138,7 @@

// Getter invocation might actually be a method extraction.

if (is_getter && function.IsNull()) {

function ^= cls.LookupDynamicFunction(field_name);

- if (!function.IsNull()) {

+ if (!function.IsNull() && !function.IsNoSuchMethodDispatcher()) {

Ivan Posva 2013/06/20 17:21:08 Please add a language test which verifies this.

Florian Schneider 2013/06/21 06:46:26 Done. Added test, but it is also covered by tests/

// We were looking for the getter but found a method with the same name.

// Create a method extractor and return it.

function ^= CreateMethodExtractor(function_name, function);

« runtime/vm/parser.cc ('K') | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »