Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: chrome/test/chromedriver/session_commands.cc

Issue 1731483003: chrome: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/chromedriver/session_commands.h" 5 #include "chrome/test/chromedriver/session_commands.h"
6 6
7 #include <list> 7 #include <list>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 const SyncWebSocketFactory& socket_factory, 60 const SyncWebSocketFactory& socket_factory,
61 DeviceManager* device_manager, 61 DeviceManager* device_manager,
62 PortServer* port_server, 62 PortServer* port_server,
63 PortManager* port_manager) 63 PortManager* port_manager)
64 : context_getter(context_getter), 64 : context_getter(context_getter),
65 socket_factory(socket_factory), 65 socket_factory(socket_factory),
66 device_manager(device_manager), 66 device_manager(device_manager),
67 port_server(port_server), 67 port_server(port_server),
68 port_manager(port_manager) {} 68 port_manager(port_manager) {}
69 69
70 InitSessionParams::InitSessionParams(const InitSessionParams& other) = default;
71
70 InitSessionParams::~InitSessionParams() {} 72 InitSessionParams::~InitSessionParams() {}
71 73
72 namespace { 74 namespace {
73 75
74 scoped_ptr<base::DictionaryValue> CreateCapabilities(Chrome* chrome) { 76 scoped_ptr<base::DictionaryValue> CreateCapabilities(Chrome* chrome) {
75 scoped_ptr<base::DictionaryValue> caps(new base::DictionaryValue()); 77 scoped_ptr<base::DictionaryValue> caps(new base::DictionaryValue());
76 caps->SetString("browserName", "chrome"); 78 caps->SetString("browserName", "chrome");
77 caps->SetString("version", chrome->GetBrowserInfo()->browser_version); 79 caps->SetString("version", chrome->GetBrowserInfo()->browser_version);
78 caps->SetString("chrome.chromedriverVersion", kChromeDriverVersion); 80 caps->SetString("chrome.chromedriverVersion", kChromeDriverVersion);
79 caps->SetString("platform", chrome->GetOperatingSystemName()); 81 caps->SetString("platform", chrome->GetOperatingSystemName());
(...skipping 630 matching lines...) Expand 10 before | Expand all | Expand 10 after
710 Status ExecuteSetAutoReporting( 712 Status ExecuteSetAutoReporting(
711 Session* session, 713 Session* session,
712 const base::DictionaryValue& params, 714 const base::DictionaryValue& params,
713 scoped_ptr<base::Value>* value) { 715 scoped_ptr<base::Value>* value) {
714 bool enabled; 716 bool enabled;
715 if (!params.GetBoolean("enabled", &enabled)) 717 if (!params.GetBoolean("enabled", &enabled))
716 return Status(kUnknownError, "missing parameter 'enabled'"); 718 return Status(kUnknownError, "missing parameter 'enabled'");
717 session->auto_reporting_enabled = enabled; 719 session->auto_reporting_enabled = enabled;
718 return Status(kOk); 720 return Status(kOk);
719 } 721 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698