Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: chrome/test/chromedriver/chrome/devtools_http_client.cc

Issue 1731483003: chrome: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/chromedriver/chrome/devtools_http_client.h" 5 #include "chrome/test/chromedriver/chrome/devtools_http_client.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/json/json_reader.h" 11 #include "base/json/json_reader.h"
12 #include "base/strings/stringprintf.h" 12 #include "base/strings/stringprintf.h"
13 #include "base/threading/platform_thread.h" 13 #include "base/threading/platform_thread.h"
14 #include "base/time/time.h" 14 #include "base/time/time.h"
15 #include "base/values.h" 15 #include "base/values.h"
16 #include "chrome/test/chromedriver/chrome/device_metrics.h" 16 #include "chrome/test/chromedriver/chrome/device_metrics.h"
17 #include "chrome/test/chromedriver/chrome/devtools_client_impl.h" 17 #include "chrome/test/chromedriver/chrome/devtools_client_impl.h"
18 #include "chrome/test/chromedriver/chrome/log.h" 18 #include "chrome/test/chromedriver/chrome/log.h"
19 #include "chrome/test/chromedriver/chrome/status.h" 19 #include "chrome/test/chromedriver/chrome/status.h"
20 #include "chrome/test/chromedriver/chrome/web_view_impl.h" 20 #include "chrome/test/chromedriver/chrome/web_view_impl.h"
21 #include "chrome/test/chromedriver/net/net_util.h" 21 #include "chrome/test/chromedriver/net/net_util.h"
22 #include "chrome/test/chromedriver/net/url_request_context_getter.h" 22 #include "chrome/test/chromedriver/net/url_request_context_getter.h"
23 23
24 WebViewInfo::WebViewInfo(const std::string& id, 24 WebViewInfo::WebViewInfo(const std::string& id,
25 const std::string& debugger_url, 25 const std::string& debugger_url,
26 const std::string& url, 26 const std::string& url,
27 Type type) 27 Type type)
28 : id(id), debugger_url(debugger_url), url(url), type(type) {} 28 : id(id), debugger_url(debugger_url), url(url), type(type) {}
29 29
30 WebViewInfo::WebViewInfo(const WebViewInfo& other) = default;
31
30 WebViewInfo::~WebViewInfo() {} 32 WebViewInfo::~WebViewInfo() {}
31 33
32 bool WebViewInfo::IsFrontend() const { 34 bool WebViewInfo::IsFrontend() const {
33 return url.find("chrome-devtools://") == 0u; 35 return url.find("chrome-devtools://") == 0u;
34 } 36 }
35 37
36 bool WebViewInfo::IsInactiveBackgroundPage() const { 38 bool WebViewInfo::IsInactiveBackgroundPage() const {
37 return type == WebViewInfo::kBackgroundPage && debugger_url.empty(); 39 return type == WebViewInfo::kBackgroundPage && debugger_url.empty();
38 } 40 }
39 41
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 Status status = ParseType(type_as_string, &type); 303 Status status = ParseType(type_as_string, &type);
302 if (status.IsError()) 304 if (status.IsError())
303 return status; 305 return status;
304 temp_views_info.push_back(WebViewInfo(id, debugger_url, url, type)); 306 temp_views_info.push_back(WebViewInfo(id, debugger_url, url, type));
305 } 307 }
306 *views_info = WebViewsInfo(temp_views_info); 308 *views_info = WebViewsInfo(temp_views_info);
307 return Status(kOk); 309 return Status(kOk);
308 } 310 }
309 311
310 } // namespace internal 312 } // namespace internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698