Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Side by Side Diff: chrome/common/extensions/api/input_ime/input_components_handler.h

Issue 1731483003: chrome: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_API_INPUT_IME_INPUT_COMPONENTS_HANDLER_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_API_INPUT_IME_INPUT_COMPONENTS_HANDLER_H_
6 #define CHROME_COMMON_EXTENSIONS_API_INPUT_IME_INPUT_COMPONENTS_HANDLER_H_ 6 #define CHROME_COMMON_EXTENSIONS_API_INPUT_IME_INPUT_COMPONENTS_HANDLER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "extensions/common/extension.h" 13 #include "extensions/common/extension.h"
14 #include "extensions/common/manifest_handler.h" 14 #include "extensions/common/manifest_handler.h"
15 #include "url/gurl.h" 15 #include "url/gurl.h"
16 16
17 namespace extensions { 17 namespace extensions {
18 18
19 class Extension; 19 class Extension;
20 20
21 enum InputComponentType { 21 enum InputComponentType {
22 INPUT_COMPONENT_TYPE_NONE = -1, 22 INPUT_COMPONENT_TYPE_NONE = -1,
23 INPUT_COMPONENT_TYPE_IME, 23 INPUT_COMPONENT_TYPE_IME,
24 INPUT_COMPONENT_TYPE_COUNT 24 INPUT_COMPONENT_TYPE_COUNT
25 }; 25 };
26 26
27 struct InputComponentInfo { 27 struct InputComponentInfo {
28 // Define out of line constructor/destructor to please Clang. 28 // Define out of line constructor/destructor to please Clang.
29 InputComponentInfo(); 29 InputComponentInfo();
30 InputComponentInfo(const InputComponentInfo& other);
30 ~InputComponentInfo(); 31 ~InputComponentInfo();
31 32
32 std::string name; 33 std::string name;
33 InputComponentType type; 34 InputComponentType type;
34 std::string id; 35 std::string id;
35 std::string description; 36 std::string description;
36 std::set<std::string> languages; 37 std::set<std::string> languages;
37 std::set<std::string> layouts; 38 std::set<std::string> layouts;
38 std::string shortcut_keycode; 39 std::string shortcut_keycode;
39 bool shortcut_alt; 40 bool shortcut_alt;
(...skipping 28 matching lines...) Expand all
68 69
69 private: 70 private:
70 const std::vector<std::string> Keys() const override; 71 const std::vector<std::string> Keys() const override;
71 72
72 DISALLOW_COPY_AND_ASSIGN(InputComponentsHandler); 73 DISALLOW_COPY_AND_ASSIGN(InputComponentsHandler);
73 }; 74 };
74 75
75 } // namespace extensions 76 } // namespace extensions
76 77
77 #endif // CHROME_COMMON_EXTENSIONS_API_INPUT_IME_INPUT_COMPONENTS_HANDLER_H_ 78 #endif // CHROME_COMMON_EXTENSIONS_API_INPUT_IME_INPUT_COMPONENTS_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698