Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: chrome/common/extensions/api/input_ime/input_components_handler.cc

Issue 1731483003: chrome: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/api/input_ime/input_components_handler.h" 5 #include "chrome/common/extensions/api/input_ime/input_components_handler.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 11 matching lines...) Expand all
22 namespace keys = manifest_keys; 22 namespace keys = manifest_keys;
23 namespace errors = manifest_errors; 23 namespace errors = manifest_errors;
24 24
25 InputComponentInfo::InputComponentInfo() 25 InputComponentInfo::InputComponentInfo()
26 : type(INPUT_COMPONENT_TYPE_NONE), 26 : type(INPUT_COMPONENT_TYPE_NONE),
27 shortcut_alt(false), 27 shortcut_alt(false),
28 shortcut_ctrl(false), 28 shortcut_ctrl(false),
29 shortcut_shift(false) { 29 shortcut_shift(false) {
30 } 30 }
31 31
32 InputComponentInfo::InputComponentInfo(const InputComponentInfo& other) =
33 default;
34
32 InputComponentInfo::~InputComponentInfo() {} 35 InputComponentInfo::~InputComponentInfo() {}
33 36
34 InputComponents::InputComponents() {} 37 InputComponents::InputComponents() {}
35 InputComponents::~InputComponents() {} 38 InputComponents::~InputComponents() {}
36 39
37 // static 40 // static
38 const std::vector<InputComponentInfo>* InputComponents::GetInputComponents( 41 const std::vector<InputComponentInfo>* InputComponents::GetInputComponents(
39 const Extension* extension) { 42 const Extension* extension) {
40 InputComponents* info = static_cast<InputComponents*>( 43 InputComponents* info = static_cast<InputComponents*>(
41 extension->GetManifestData(keys::kInputComponents)); 44 extension->GetManifestData(keys::kInputComponents));
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 const std::vector<std::string> 238 const std::vector<std::string>
236 InputComponentsHandler::PrerequisiteKeys() const { 239 InputComponentsHandler::PrerequisiteKeys() const {
237 return SingleKey(keys::kOptionsPage); 240 return SingleKey(keys::kOptionsPage);
238 } 241 }
239 242
240 const std::vector<std::string> InputComponentsHandler::Keys() const { 243 const std::vector<std::string> InputComponentsHandler::Keys() const {
241 return SingleKey(keys::kInputComponents); 244 return SingleKey(keys::kInputComponents);
242 } 245 }
243 246
244 } // namespace extensions 247 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698