Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/browser/ui/webui/browsing_history_handler.cc

Issue 1731483003: chrome: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/browsing_history_handler.h" 5 #include "chrome/browser/ui/webui/browsing_history_handler.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <set> 9 #include <set>
10 10
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 this->is_search_result = is_search_result; 173 this->is_search_result = is_search_result;
174 this->snippet = snippet; 174 this->snippet = snippet;
175 this->blocked_visit = blocked_visit; 175 this->blocked_visit = blocked_visit;
176 this->accept_languages = accept_languages; 176 this->accept_languages = accept_languages;
177 } 177 }
178 178
179 BrowsingHistoryHandler::HistoryEntry::HistoryEntry() 179 BrowsingHistoryHandler::HistoryEntry::HistoryEntry()
180 : entry_type(EMPTY_ENTRY), is_search_result(false), blocked_visit(false) { 180 : entry_type(EMPTY_ENTRY), is_search_result(false), blocked_visit(false) {
181 } 181 }
182 182
183 BrowsingHistoryHandler::HistoryEntry::HistoryEntry(const HistoryEntry& other) =
184 default;
185
183 BrowsingHistoryHandler::HistoryEntry::~HistoryEntry() { 186 BrowsingHistoryHandler::HistoryEntry::~HistoryEntry() {
184 } 187 }
185 188
186 void BrowsingHistoryHandler::HistoryEntry::SetUrlAndTitle( 189 void BrowsingHistoryHandler::HistoryEntry::SetUrlAndTitle(
187 base::DictionaryValue* result) const { 190 base::DictionaryValue* result) const {
188 result->SetString("url", url.spec()); 191 result->SetString("url", url.spec());
189 192
190 bool using_url_as_the_title = false; 193 bool using_url_as_the_title = false;
191 base::string16 title_to_set(title); 194 base::string16 title_to_set(title);
192 if (title.empty()) { 195 if (title.empty()) {
(...skipping 719 matching lines...) Expand 10 before | Expand all | Expand 10 after
912 915
913 void BrowsingHistoryHandler::OnURLsDeleted( 916 void BrowsingHistoryHandler::OnURLsDeleted(
914 history::HistoryService* history_service, 917 history::HistoryService* history_service,
915 bool all_history, 918 bool all_history,
916 bool expired, 919 bool expired,
917 const history::URLRows& deleted_rows, 920 const history::URLRows& deleted_rows,
918 const std::set<GURL>& favicon_urls) { 921 const std::set<GURL>& favicon_urls) {
919 if (all_history || DeletionsDiffer(deleted_rows, urls_to_be_deleted_)) 922 if (all_history || DeletionsDiffer(deleted_rows, urls_to_be_deleted_))
920 web_ui()->CallJavascriptFunction("historyDeleted"); 923 web_ui()->CallJavascriptFunction("historyDeleted");
921 } 924 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698