chrome: Add out-of-line copy ctors for complex classes.

chrome/browser/ui/app_list/app_list_prefs.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_APP_LIST_APP_LIST_PREFS_H_
 #define CHROME_BROWSER_UI_APP_LIST_APP_LIST_PREFS_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 25 matching lines @@
       ITEM_TYPE_INVALID = 0,
       ITEM_TYPE_BEGIN,
       APP_ITEM = ITEM_TYPE_BEGIN,
       FOLDER_ITEM,
 
       // Do not change the order of this enum.
       // When adding values, remember to update ITEM_TYPE_END.
       ITEM_TYPE_END = FOLDER_ITEM,
     };
     AppListInfo();
+    AppListInfo(const AppListInfo& other);

[tapted, 2016/02/24 00:36:13]

Pretty sure this can be `= delete` -- only the assignment operator is used for
`AppListInfo`

[vmpstr, 2016/02/24 00:43:06]

If I delete it, then there's a compiler error on this line:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/....

Here's the error:

/work/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_pair.h:104:21:
error: call to deleted constructor of 'app_list::AppListPrefs::AppListInfo'
      : first(__a), second(__b) { }
                    ^      ~~~
/work/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_map.h:453:29:
note: in instantiation of member function 'std::pair<const
std::basic_string<char>, app_list::AppListPrefs::AppListInfo>::pair' requested
here
          __i = insert(__i, value_type(__k, mapped_type()));
                            ^
../../chrome/browser/ui/app_list/app_list_prefs.cc:120:11: note: in
instantiation of member function 'std::map<std::basic_string<char>,
app_list::AppListPrefs::AppListInfo, std::less<std::basic_string<char> >,
std::allocator<std::pair<const std::basic_string<char>,
app_list::AppListPrefs::AppListInfo> > >::operator[]' requested here
    (*out)[it.key()] = *AppListInfo::CreateAppListInfoFromDict(item_dict);
          ^
../../chrome/browser/ui/app_list/app_list_prefs.h:46:5: note: 'AppListInfo' has
been explicitly marked deleted here
    AppListInfo(const AppListInfo& other) = delete;
    ^

I think it happens because [] operator creates an empty value and then inserts
it via a copy constructor, but I'm not too sure.

     ~AppListInfo();
     scoped_ptr<base::DictionaryValue> CreateDictFromAppListInfo() const;
 
     static scoped_ptr<AppListPrefs::AppListInfo> CreateAppListInfoFromDict(
         const base::DictionaryValue* item_dict);
 
     // The id of the folder containing this item.
     std::string parent_id;
 
     // The name of this item.
@@ skipping 32 matching lines @@
   explicit AppListPrefs(PrefService* pref_service);
 
   PrefService* pref_service_;
 
   DISALLOW_COPY_AND_ASSIGN(AppListPrefs);
 };
 
 }  // namespace app_list
 
 #endif  // CHROME_BROWSER_UI_APP_LIST_APP_LIST_PREFS_H_