Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Side by Side Diff: chrome/browser/net/url_info.h

Issue 1731483003: chrome: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // A UrlInfo object is used to store prediction related information about a host 5 // A UrlInfo object is used to store prediction related information about a host
6 // port and scheme triplet. When performing DNS pre-resolution of the host/port 6 // port and scheme triplet. When performing DNS pre-resolution of the host/port
7 // pair, its state is monitored as it is resolved. 7 // pair, its state is monitored as it is resolved.
8 // It includes progress, from placement in the Predictor's queue, to resolution 8 // It includes progress, from placement in the Predictor's queue, to resolution
9 // by the DNS service as either FOUND or NO_SUCH_NAME. Each instance may also 9 // by the DNS service as either FOUND or NO_SUCH_NAME. Each instance may also
10 // hold records of previous resolution times, which might later be shown to be 10 // hold records of previous resolution times, which might later be shown to be
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 typedef std::vector<UrlInfo> UrlInfoTable; 68 typedef std::vector<UrlInfo> UrlInfoTable;
69 69
70 static base::TimeDelta NullDuration() { 70 static base::TimeDelta NullDuration() {
71 return base::TimeDelta::FromMilliseconds(-1); 71 return base::TimeDelta::FromMilliseconds(-1);
72 } 72 }
73 73
74 // UrlInfo are usually made by the default constructor during 74 // UrlInfo are usually made by the default constructor during
75 // initializing of the Predictor's map (of info for Hostnames). 75 // initializing of the Predictor's map (of info for Hostnames).
76 UrlInfo(); 76 UrlInfo();
77 77
78 UrlInfo(const UrlInfo& other);
79
78 ~UrlInfo(); 80 ~UrlInfo();
79 81
80 // NeedDnsUpdate decides, based on our internal info, 82 // NeedDnsUpdate decides, based on our internal info,
81 // if it would be valuable to attempt to update (prefectch) 83 // if it would be valuable to attempt to update (prefectch)
82 // DNS data for hostname. This decision is based 84 // DNS data for hostname. This decision is based
83 // on how recently we've done DNS prefetching for hostname. 85 // on how recently we've done DNS prefetching for hostname.
84 bool NeedsDnsUpdate(); 86 bool NeedsDnsUpdate();
85 87
86 // FOR TEST ONLY: The following access the otherwise constant values. 88 // FOR TEST ONLY: The following access the otherwise constant values.
87 static void set_cache_expiration(base::TimeDelta time); 89 static void set_cache_expiration(base::TimeDelta time);
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 GURL referring_url_; 181 GURL referring_url_;
180 182
181 // We put these objects into a std::map, and hence we 183 // We put these objects into a std::map, and hence we
182 // need some "evil" constructors. 184 // need some "evil" constructors.
183 // DISALLOW_COPY_AND_ASSIGN(UrlInfo); 185 // DISALLOW_COPY_AND_ASSIGN(UrlInfo);
184 }; 186 };
185 187
186 } // namespace chrome_browser_net 188 } // namespace chrome_browser_net
187 189
188 #endif // CHROME_BROWSER_NET_URL_INFO_H_ 190 #endif // CHROME_BROWSER_NET_URL_INFO_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698