Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: chrome/browser/media/router/issue.cc

Issue 1731483003: chrome: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/guid.h" 5 #include "base/guid.h"
6 #include "chrome/browser/media/router/issue.h" 6 #include "chrome/browser/media/router/issue.h"
7 7
8 namespace media_router { 8 namespace media_router {
9 9
10 IssueAction::IssueAction(const IssueAction::Type type) : type_(type) { 10 IssueAction::IssueAction(const IssueAction::Type type) : type_(type) {
(...skipping 20 matching lines...) Expand all
31 is_blocking_(is_blocking), 31 is_blocking_(is_blocking),
32 help_url_(GURL(help_url)) { 32 help_url_(GURL(help_url)) {
33 DCHECK(!title_.empty()); 33 DCHECK(!title_.empty());
34 DCHECK(severity_ != FATAL || is_blocking_) << "Severity is " << severity_; 34 DCHECK(severity_ != FATAL || is_blocking_) << "Severity is " << severity_;
35 35
36 // Check that the default and secondary actions are not of the same type. 36 // Check that the default and secondary actions are not of the same type.
37 if (!secondary_actions_.empty()) 37 if (!secondary_actions_.empty())
38 DCHECK_NE(default_action_.type(), secondary_actions_[0].type()); 38 DCHECK_NE(default_action_.type(), secondary_actions_[0].type());
39 } 39 }
40 40
41 Issue::Issue(const Issue& other) = default;
42
41 Issue::~Issue() { 43 Issue::~Issue() {
42 } 44 }
43 45
44 bool Issue::Equals(const Issue& other) const { 46 bool Issue::Equals(const Issue& other) const {
45 return id_ == other.id_; 47 return id_ == other.id_;
46 } 48 }
47 49
48 } // namespace media_router 50 } // namespace media_router
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698