Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/browser/extensions/extension_sync_data.cc

Issue 1731483003: chrome: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_sync_data.h" 5 #include "chrome/browser/extensions/extension_sync_data.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "chrome/browser/extensions/extension_service.h" 10 #include "chrome/browser/extensions/extension_service.h"
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 LinkedAppIcons::GetLinkedAppIcons(&extension); 127 LinkedAppIcons::GetLinkedAppIcons(&extension);
128 for (const auto& icon : icons.icons) { 128 for (const auto& icon : icons.icons) {
129 LinkedAppIconInfo linked_icon; 129 LinkedAppIconInfo linked_icon;
130 linked_icon.url = icon.url; 130 linked_icon.url = icon.url;
131 linked_icon.size = icon.size; 131 linked_icon.size = icon.size;
132 linked_icons_.push_back(linked_icon); 132 linked_icons_.push_back(linked_icon);
133 } 133 }
134 } 134 }
135 } 135 }
136 136
137 ExtensionSyncData::ExtensionSyncData(const ExtensionSyncData& other) = default;
138
137 ExtensionSyncData::~ExtensionSyncData() {} 139 ExtensionSyncData::~ExtensionSyncData() {}
138 140
139 // static 141 // static
140 scoped_ptr<ExtensionSyncData> ExtensionSyncData::CreateFromSyncData( 142 scoped_ptr<ExtensionSyncData> ExtensionSyncData::CreateFromSyncData(
141 const syncer::SyncData& sync_data) { 143 const syncer::SyncData& sync_data) {
142 scoped_ptr<ExtensionSyncData> data(new ExtensionSyncData); 144 scoped_ptr<ExtensionSyncData> data(new ExtensionSyncData);
143 if (data->PopulateFromSyncData(sync_data)) 145 if (data->PopulateFromSyncData(sync_data))
144 return data; 146 return data;
145 return nullptr; 147 return nullptr;
146 } 148 }
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 317
316 if (entity_specifics.has_extension()) 318 if (entity_specifics.has_extension())
317 return PopulateFromExtensionSpecifics(entity_specifics.extension()); 319 return PopulateFromExtensionSpecifics(entity_specifics.extension());
318 320
319 LOG(ERROR) << "Attempt to sync bad EntitySpecifics: no extension data."; 321 LOG(ERROR) << "Attempt to sync bad EntitySpecifics: no extension data.";
320 RecordBadSyncData(NO_EXTENSION_SPECIFICS); 322 RecordBadSyncData(NO_EXTENSION_SPECIFICS);
321 return false; 323 return false;
322 } 324 }
323 325
324 } // namespace extensions 326 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698