Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Side by Side Diff: chrome/browser/extensions/chrome_app_sorting.h

Issue 1731483003: chrome: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_
6 #define CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_ 6 #define CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 friend class ChromeAppSortingPageOrdinalMapping; 78 friend class ChromeAppSortingPageOrdinalMapping;
79 friend class ChromeAppSortingSetExtensionVisible; 79 friend class ChromeAppSortingSetExtensionVisible;
80 80
81 // An enum used by GetMinOrMaxAppLaunchOrdinalsOnPage to specify which 81 // An enum used by GetMinOrMaxAppLaunchOrdinalsOnPage to specify which
82 // value should be returned. 82 // value should be returned.
83 enum AppLaunchOrdinalReturn {MIN_ORDINAL, MAX_ORDINAL}; 83 enum AppLaunchOrdinalReturn {MIN_ORDINAL, MAX_ORDINAL};
84 84
85 // Maps an app id to its ordinals. 85 // Maps an app id to its ordinals.
86 struct AppOrdinals { 86 struct AppOrdinals {
87 AppOrdinals(); 87 AppOrdinals();
88 AppOrdinals(const AppOrdinals& other);
88 ~AppOrdinals(); 89 ~AppOrdinals();
89 90
90 syncer::StringOrdinal page_ordinal; 91 syncer::StringOrdinal page_ordinal;
91 syncer::StringOrdinal app_launch_ordinal; 92 syncer::StringOrdinal app_launch_ordinal;
92 }; 93 };
93 typedef std::map<std::string, AppOrdinals> AppOrdinalsMap; 94 typedef std::map<std::string, AppOrdinals> AppOrdinalsMap;
94 95
95 // This function returns the lowest ordinal on |page_ordinal| if 96 // This function returns the lowest ordinal on |page_ordinal| if
96 // |return_value| == AppLaunchOrdinalReturn::MIN_ORDINAL, otherwise it returns 97 // |return_value| == AppLaunchOrdinalReturn::MIN_ORDINAL, otherwise it returns
97 // the largest ordinal on |page_ordinal|. If there are no apps on the page 98 // the largest ordinal on |page_ordinal|. If there are no apps on the page
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 173
173 // The set of extensions that don't appear in the new tab page. 174 // The set of extensions that don't appear in the new tab page.
174 std::set<std::string> ntp_hidden_extensions_; 175 std::set<std::string> ntp_hidden_extensions_;
175 176
176 DISALLOW_COPY_AND_ASSIGN(ChromeAppSorting); 177 DISALLOW_COPY_AND_ASSIGN(ChromeAppSorting);
177 }; 178 };
178 179
179 } // namespace extensions 180 } // namespace extensions
180 181
181 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_ 182 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698