Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1731423002: printing: Add out-of-line copy ctors for complex classes. (Closed)

Created:
4 years, 10 months ago by vmpstr
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang, Nico, dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

printing: Add out-of-line copy ctors for complex classes. This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=thestig@chromium.org, dcheng@chromium.org, thakis@chromium.org Committed: https://crrev.com/04b8358f3650f0bf5e2250b89d0ef1be6c151e13 Cr-Commit-Position: refs/heads/master@{#377762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M printing/backend/print_backend.h View 2 chunks +2 lines, -0 lines 0 comments Download
M printing/backend/print_backend.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M printing/page_setup.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/page_setup.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/print_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/print_settings.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vmpstr
Please take a look.
4 years, 10 months ago (2016-02-24 18:51:59 UTC) #1
dcheng
lgtm
4 years, 10 months ago (2016-02-24 18:52:18 UTC) #2
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-24 19:03:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731423002/1
4 years, 10 months ago (2016-02-26 00:03:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 01:38:49 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 01:41:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04b8358f3650f0bf5e2250b89d0ef1be6c151e13
Cr-Commit-Position: refs/heads/master@{#377762}

Powered by Google App Engine
This is Rietveld 408576698