Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 1731413002: Hide GrDrawTarget from GrOvalRenderer (Closed)

Created:
4 years, 10 months ago by robertphillips
Modified:
4 years, 10 months ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix overlength lines #

Patch Set 3 : Move DRRect method into DrawContext #

Patch Set 4 : clean up #

Patch Set 5 : clean up #

Patch Set 6 : Fix memory bug #

Patch Set 7 : erg! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -238 lines) Patch
M src/gpu/GrDrawContext.cpp View 1 2 3 4 5 6 chunks +109 lines, -28 lines 0 comments Download
M src/gpu/GrOvalRenderer.h View 1 2 3 4 2 chunks +28 lines, -43 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 3 11 chunks +51 lines, -167 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
robertphillips
4 years, 10 months ago (2016-02-24 20:23:17 UTC) #5
joshualitt
On 2016/02/24 20:23:17, robertphillips wrote: lgtm
4 years, 10 months ago (2016-02-24 20:59:47 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731413002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731413002/120001
4 years, 10 months ago (2016-02-24 21:04:00 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 21:34:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731413002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731413002/120001
4 years, 10 months ago (2016-02-24 21:36:08 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 21:37:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/0cc2f85a19d50b45573d71d8c9d6ee1292c9fd3a

Powered by Google App Engine
This is Rietveld 408576698