media: Add out-of-line copy ctors for complex classes.

media: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=dalecurtis@chromium.org, dcheng@chromium.org, thakis@chromium.org

Committed: https://crrev.com/9750c9d9a4b7c8b84716facbf16c735ae9b355bf
Cr-Commit-Position: refs/heads/master@{#377967}

[vmpstr, 2016-02-24 18:36:37]

Please take a look.

[dcheng, 2016-02-24 18:38:37]

lgtm

[DaleCurtis, 2016-02-24 20:20:38]

Adds some noise, but seems to have grand savings, so lgtm

[DaleCurtis, 2016-02-24 20:21:02]

You have numbers on other binaries in the bug, how does this affect the final
size?

[vmpstr, 2016-02-24 21:46:52]

On 2016/02/24 20:21:02, DaleCurtis wrote:
> You have numbers on other binaries in the bug, how does this affect the final
> size?

Ya comment 11 and 14 in the bug are about the binary sizes (release is about
150k savings i think)

[vmpstr, 2016-02-24 21:47:08]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-02-24 21:48:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731403002/1

[DaleCurtis, 2016-02-24 21:51:45]

Ah, I missed that comment w/ all the totals. Thanks! Nice work.

[commit-bot: I haz the power, 2016-02-24 22:00:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 22:00:22]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[vmpstr, 2016-02-25 22:54:30]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-02-25 22:57:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731403002/1

[commit-bot: I haz the power, 2016-02-25 23:43:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 23:43:05]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[vmpstr, 2016-02-26 19:43:14]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-02-26 19:46:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731403002/1

[commit-bot: I haz the power, 2016-02-26 20:49:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-26 20:50:31]

Description was changed from

==========
media: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=dalecurtis@chromium.org, dcheng@chromium.org, thakis@chromium.org
==========

to

==========
media: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=dalecurtis@chromium.org, dcheng@chromium.org, thakis@chromium.org

Committed: https://crrev.com/9750c9d9a4b7c8b84716facbf16c735ae9b355bf
Cr-Commit-Position: refs/heads/master@{#377967}
==========

[commit-bot: I haz the power, 2016-02-26 20:50:32]

Patchset 1 (id:??) landed as
https://crrev.com/9750c9d9a4b7c8b84716facbf16c735ae9b355bf
Cr-Commit-Position: refs/heads/master@{#377967}