RuleSet causes 600 kB of memory fragmentation

Source/wtf/LinkedStack.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef WebInbandTextTrack_h
-#define WebInbandTextTrack_h
+#ifndef LinkedStack_h

[esprehn, 2013/06/20 22:29:52]

I hate the git diff similarity stuff :/

+#define LinkedStack_h
 
-namespace WebKit {
+#include "wtf/OwnPtr.h"
 
-class WebString;
-class WebInbandTextTrackClient;
+namespace WTF {
 
-class WebInbandTextTrack {
+template <typename T>
+class LinkedStack {
 public:
-    enum Kind {
-        KindSubtitles,
-        KindCaptions,
-        KindDescriptions,
-        KindChapters,
-        KindMetadata,
-        KindNone
+    LinkedStack() { }

[esprehn, 2013/06/20 22:29:52]

You can leave this out, we can use the default one.

[abarth-chromium, 2013/06/20 22:52:32]

Very true.

+
+    bool isEmpty();
+
+    void push(const T&);
+    const T& peek();
+    void pop();
+
+    size_t size();
+
+private:
+    struct Node {
+        Node(const T&, PassOwnPtr<Node> next);
+
+        T m_data;
+        OwnPtr<Node> m_next;
     };
 
-    enum Mode {
-        ModeDisabled,
-        ModeHidden,
-        ModeShowing
-    };
-
-    virtual ~WebInbandTextTrack() {}
-
-    virtual void setClient(WebInbandTextTrackClient*) = 0;
-    virtual WebInbandTextTrackClient* client() = 0;
-
-    virtual void setMode(Mode) = 0;
-    virtual Mode mode() const = 0;
-
-    virtual Kind kind() const = 0;
-    virtual bool isClosedCaptions() const = 0;
-
-    virtual WebString label() const = 0;
-    virtual WebString language() const = 0;
-    virtual bool isDefault() const = 0;
-
-    virtual int textTrackIndex() const = 0;
+    OwnPtr<Node> m_head;
 };
 
-} // namespace WebKit
+template <typename T>
+LinkedStack<T>::Node::Node(const T& data, PassOwnPtr<Node> next)
+    : m_data(data)
+    , m_next(next)
+{
+}
+
+template <typename T>
+inline bool LinkedStack<T>::isEmpty()
+{
+    return !m_head;
+}
+
+template <typename T>
+inline void LinkedStack<T>::push(const T& data)
+{
+    m_head = adoptPtr(new Node(data, m_head.release()));
+}
+
+template <typename T>
+inline const T& LinkedStack<T>::peek()
+{
+    return m_head->m_data;
+}
+
+template <typename T>
+inline void LinkedStack<T>::pop()
+{
+    m_head = m_head->m_next.release();
+}
+
+template <typename T>
+inline size_t LinkedStack<T>::size()

[esprehn, 2013/06/20 22:29:52]

I'd rather we just store the size inside here. Having this thing be a little bit
bigger seems fine.

[abarth-chromium, 2013/06/20 22:52:32]

Ok.

+{
+    size_t result = 0;
+    Node* current = m_head.get();
+    while (current) {
+        ++result;
+        current = current->m_next.get();
+    }
+    return result;
+}
+
+}
+
+using WTF::LinkedStack;
 
 #endif