Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1731383003: X87: [compiler] Drop the CompareNilIC. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [compiler] Drop the CompareNilIC. port 666aec0348c8793e61c8633dee7ad29a514239ba (r34237) original commit message: Since both null and undefined are also marked as undetectable now, we can just test that bit instead of having the CompareNilIC try to collect feedback to speed up the general case (without the undetectable bit being used). Drive-by-fix: Update the type system to match the new handling of undetectable in the runtime. BUG= Committed: https://crrev.com/b915411c29d38ceda842bdceab0c70a7c3760850 Cr-Commit-Position: refs/heads/master@{#34270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-25 02:18:08 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-25 03:21:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731383003/1
4 years, 10 months ago (2016-02-25 05:42:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 06:01:00 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 06:02:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b915411c29d38ceda842bdceab0c70a7c3760850
Cr-Commit-Position: refs/heads/master@{#34270}

Powered by Google App Engine
This is Rietveld 408576698