Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1731373003: ipc: Add out-of-line copy ctors for complex classes. (Closed)

Created:
4 years, 10 months ago by vmpstr
Modified:
4 years, 10 months ago
Reviewers:
Nico, jam, dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Add out-of-line copy ctors for complex classes. This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=jam@chromium.org, dcheng@chromium.org, thakis@chromium.org Committed: https://crrev.com/665ede55ed8c60b7491dd87d82ebaa97bc10c873 Cr-Commit-Position: refs/heads/master@{#377390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ipc/attachment_broker.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/attachment_broker.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vmpstr
Please take a look.
4 years, 10 months ago (2016-02-24 18:31:46 UTC) #1
dcheng
lgtm
4 years, 10 months ago (2016-02-24 18:44:39 UTC) #2
jam
lgtm
4 years, 10 months ago (2016-02-24 19:21:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731373003/1
4 years, 10 months ago (2016-02-24 19:57:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 21:26:19 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 21:28:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/665ede55ed8c60b7491dd87d82ebaa97bc10c873
Cr-Commit-Position: refs/heads/master@{#377390}

Powered by Google App Engine
This is Rietveld 408576698