Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 1731373002: Allow to have a transparent UA dependent background. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Decouple background color and transparency in RenderWidgetHostView Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc
index 9cdceb518eefad1e7dd47f841d32010a917e8044..58cf7d982d36abc793e8ea0de29e6a10ddf516a2 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.cc
+++ b/content/browser/renderer_host/render_widget_host_view_base.cc
@@ -371,6 +371,7 @@ const int kFlushInputRateInUs = 16666;
RenderWidgetHostViewBase::RenderWidgetHostViewBase()
: popup_type_(blink::WebPopupTypeNone),
background_color_(SK_ColorWHITE),
+ background_opaque_(false),
mouse_locked_(false),
showing_context_menu_(false),
selection_text_offset_(0),
@@ -415,8 +416,12 @@ void RenderWidgetHostViewBase::SetBackgroundColorToDefault() {
SetBackgroundColor(SK_ColorWHITE);
}
+void RenderWidgetHostViewBase::SetBackgroundOpaque(bool opaque) {
+ background_opaque_ = opaque;
+}
+
bool RenderWidgetHostViewBase::GetBackgroundOpaque() {
- return SkColorGetA(background_color_) == SK_AlphaOPAQUE;
+ return background_opaque_;
}
gfx::Size RenderWidgetHostViewBase::GetPhysicalBackingSize() const {

Powered by Google App Engine
This is Rietveld 408576698