Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1731373002: Allow to have a transparent UA dependent background. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 2edae31c9bd16dcf71b9fbeb9b5191e72fbfeb29..89fe983205c81d3e52033f6fcb4b9ce4fddae398 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -2128,8 +2128,12 @@ void BrowserView::InitViews() {
devtools_web_view_->SetVisible(false);
contents_container_ = new views::View();
+ // FIXME: Clear alpha only upon a call to
+ // content::RenderWidgetHostView->SetBackgroundColor(SK_ColorTRANSPARENT).
contents_container_->set_background(views::Background::CreateSolidBackground(
- GetThemeProvider()->GetColor(ThemeProperties::COLOR_CONTROL_BACKGROUND)));
+ GetThemeProvider()->GetColor(ThemeProperties::COLOR_CONTROL_BACKGROUND) &
+ 0x00FFFFFF));
trchen 2016/02/25 02:30:12 What does this mean? Is it pre-multiplied alpha or
Julien Isorce Samsung 2016/02/25 11:33:55 Sorry for the confusion, this code has no intentio
+
contents_container_->AddChildView(devtools_web_view_);
contents_container_->AddChildView(contents_web_view_);
contents_container_->SetLayoutManager(new ContentsLayoutManager(

Powered by Google App Engine
This is Rietveld 408576698