third_party/WebKit/LayoutTests/fast/events/iframe-mousewheel.html - Issue 1731353003: Prevent propagation of wheel events to dispatch event in parent iframe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/iframe-mousewheel.html

Issue 1731353003: Prevent propagation of wheel events to dispatch event in parent iframe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/iframe-mousewheel-expected.txt » ('j') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/iframe-mousewheel.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/iframe-onmousemove.html b/third_party/WebKit/LayoutTests/fast/events/iframe-mousewheel.html

similarity index 55%

copy from third_party/WebKit/LayoutTests/fast/events/iframe-onmousemove.html

copy to third_party/WebKit/LayoutTests/fast/events/iframe-mousewheel.html

index e79164b5989a34df6b053ccdbc4951dde312a7ba..f0eaf7e0025d0fbb40da89bff7c511e6ee47f3c1 100644

--- a/third_party/WebKit/LayoutTests/fast/events/iframe-onmousemove.html

+++ b/third_party/WebKit/LayoutTests/fast/events/iframe-mousewheel.html

@@ -1,19 +1,32 @@

-<html>

-<head>

+<p id="description"></p>

+<iframe id="frame" src="resources/iframe-mousewheel.html"></iframe>

+<div id="console"></div>

if (window.testRunner)

testRunner.waitUntilDone();

var testFinished = false;

-function done()

+description("This test can be used to verify that a mousewheel event is fired when wheeling over the subframe but not dispatched to the parent frame.");

+document.addEventListener("mousewheel", function() {

Rick Byers 2016/02/25 16:34:16 nit: new tests should test the standard 'wheel' ev

+ testFailed("Received wheel event in parent");

+ if (window.testRunner)

+ testRunner.notifyDone();

+});

+function iframeMouseWheel()

{

if (testFinished)

return;

testFinished = true;

- testPassed("received mousemove event.");

- debug('<br /><span class="pass">TEST COMPLETE</span>');

+ setTimeout(done, 0);

+function done()

+ testPassed("received mousewheel event.");

if (window.testRunner)

testRunner.notifyDone();

}

@@ -27,17 +40,8 @@ function runTest()

var centerX = frame.offsetLeft + frame.offsetWidth / 2;

var centerY = frame.offsetTop + frame.offsetHeight / 2;

eventSender.mouseMoveTo(centerX, centerY);

+ eventSender.mouseScrollBy(0, 53);

}

window.onload = runTest;

</script>

-</head>

-<body>

-<p id="description"></p>

-<iframe id="frame" src="resources/iframe-onmousemove.html"></iframe>

-<div id="console"></div>

-<script>

- description("This test can be used to verify that a mousemove event is fired when moving the mouse cursor over an element in a subframe.");

-</script>

-</body>

-</html>