Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1731353003: Prevent propagation of wheel events to dispatch event in parent iframe. (Closed)

Created:
4 years, 9 months ago by dtapuska
Modified:
4 years, 9 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent propagation of wheel events to dispatch event in parent iframe. If the wheel event was unhandled in the iframe prevent it from being dispatched in the parent's DOM. Do the parent's scroll action if necesary. This code can be cleaned up when we enable wheel gestures by default everywhere since it can just be an early return. BUG=589406, 564042 Committed: https://crrev.com/4c40c8928c3e27c4fb09ac945b749669d3dbf8fc Cr-Commit-Position: refs/heads/master@{#378243}

Patch Set 1 #

Patch Set 2 : Forgot to add LayoutTest #

Patch Set 3 : Fix unit test #

Total comments: 2

Patch Set 4 : Fix nits #

Patch Set 5 : Fix case where plugin was not a local frame #

Patch Set 6 : Fix mac #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -46 lines) Patch
A + third_party/WebKit/LayoutTests/fast/events/iframe-mousewheel.html View 1 2 3 2 chunks +19 lines, -15 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/iframe-mousewheel-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/events/resources/iframe-mousewheel.html View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 3 4 5 6 2 chunks +15 lines, -24 lines 0 comments Download

Messages

Total messages: 31 (16 generated)
dtapuska
4 years, 9 months ago (2016-02-25 14:45:39 UTC) #3
Rick Byers
LGTM with nits https://codereview.chromium.org/1731353003/diff/40001/third_party/WebKit/LayoutTests/fast/events/iframe-mousewheel.html File third_party/WebKit/LayoutTests/fast/events/iframe-mousewheel.html (right): https://codereview.chromium.org/1731353003/diff/40001/third_party/WebKit/LayoutTests/fast/events/iframe-mousewheel.html#newcode13 third_party/WebKit/LayoutTests/fast/events/iframe-mousewheel.html:13: document.addEventListener("mousewheel", function() { nit: new tests ...
4 years, 9 months ago (2016-02-25 16:34:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731353003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731353003/60001
4 years, 9 months ago (2016-02-25 22:33:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/130924) win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 9 months ago (2016-02-25 23:28:48 UTC) #9
dtapuska
On 2016/02/25 23:28:48, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 9 months ago (2016-02-26 16:46:18 UTC) #10
Rick Byers
Nice cleanup, thanks! LGTM
4 years, 9 months ago (2016-02-26 16:59:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731353003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731353003/100001
4 years, 9 months ago (2016-02-26 20:11:58 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/28359)
4 years, 9 months ago (2016-02-26 20:52:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731353003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731353003/100001
4 years, 9 months ago (2016-02-29 14:49:48 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/165657) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-02-29 14:52:37 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731353003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731353003/120001
4 years, 9 months ago (2016-02-29 15:15:57 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/181283)
4 years, 9 months ago (2016-02-29 17:06:08 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731353003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731353003/120001
4 years, 9 months ago (2016-02-29 17:48:43 UTC) #27
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 9 months ago (2016-02-29 18:58:52 UTC) #29
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 19:00:23 UTC) #31
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/4c40c8928c3e27c4fb09ac945b749669d3dbf8fc
Cr-Commit-Position: refs/heads/master@{#378243}

Powered by Google App Engine
This is Rietveld 408576698