Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1731333002: Revert of Include glGetMultisamplefv API (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Include glGetMultisamplefv API (patchset #1 id:1 of https://codereview.chromium.org/1720963002/ ) Reason for revert: This is in the blamelist for Visualbench failures: https://build.chromium.org/p/client.skia/builders/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-VisualBench/builds/1035 and seems the most likely candidate for the failure, so I am tentatively reverting. Original issue's description: > Include glGetMultisamplefv API > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720963002 > > Committed: https://skia.googlesource.com/skia/+/69c1b24bcaa7cffd59753a75a7f3d155696fcac4 TBR=bsalomon@google.com,joshualitt@google.com,cdalton@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/f15b07b75ce6b1ad2bde91b3baf17ef9210241b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M include/gpu/GrCaps.h View 2 chunks +0 lines, -2 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrCaps.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
ethannicholas
Created Revert of Include glGetMultisamplefv API
4 years, 10 months ago (2016-02-24 16:18:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731333002/1
4 years, 10 months ago (2016-02-24 16:18:54 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 16:19:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f15b07b75ce6b1ad2bde91b3baf17ef9210241b3

Powered by Google App Engine
This is Rietveld 408576698