chrome/browser/safe_browsing/client_side_detection_service.cc - Issue 173133004: Separate pre-classification checks for client-side malware and phishing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.cc

Issue 173133004: Separate pre-classification checks for client-side malware and phishing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Set right enum type for boolean histograms. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_host_unittest.cc ('k') | chrome/browser/safe_browsing/client_side_detection_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service.cc b/chrome/browser/safe_browsing/client_side_detection_service.cc

index d63e45cbfd931b57fd880f4d48c40c168454bbbe..d045bd92f986bdb383d437c264147a2dcbc2c2b4 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service.cc

@@ -368,15 +368,6 @@ void ClientSideDetectionService::StartClientReportMalwareRequest(

return;

}

- if (OverMalwareReportLimit()) {

- UpdateEnumUMAHistogram(REPORT_HIT_LIMIT);

- DVLOG(1) << "Too many malware report requests sent recently."

- << "Skip sending malware report for " << GURL(request->url());

- if (!callback.is_null())

- callback.Run(GURL(request->url()), GURL(request->url()), false);

- return;

- }

std::string request_data;

if (!request->SerializeToString(&request_data)) {

UpdateEnumUMAHistogram(REPORT_FAILED_SERIALIZATION);