chrome/browser/safe_browsing/browser_feature_extractor.cc - Issue 173133004: Separate pre-classification checks for client-side malware and phishing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/browser_feature_extractor.cc

Issue 173133004: Separate pre-classification checks for client-side malware and phishing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change some of the histograms to bool histograms when appropriate. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/browser_feature_extractor.h ('k') | chrome/browser/safe_browsing/client_side_detection_host.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/browser_feature_extractor.cc

diff --git a/chrome/browser/safe_browsing/browser_feature_extractor.cc b/chrome/browser/safe_browsing/browser_feature_extractor.cc

index 522c3fc07d69a96dc57f855518a5d59cd75e4bf5..8d0bd73577bf5b4cf6d8b1f6e26d56e607fae5fa 100644

--- a/chrome/browser/safe_browsing/browser_feature_extractor.cc

+++ b/chrome/browser/safe_browsing/browser_feature_extractor.cc

@@ -262,7 +262,6 @@ void BrowserFeatureExtractor::ExtractMalwareFeatures(

ClientMalwareRequest* request,

const MalwareDoneCallback& callback) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

- DCHECK_EQ(0U, request->url().find("http:"));

DCHECK(!callback.is_null());

// Grab the IPs because they might go away before we're done