Tools/GardeningServer/scripts/model_unittests.js - Issue 173133003: Convert garden-o-matic guts over to promises where appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/GardeningServer/scripts/model_unittests.js

Issue 173133003: Convert garden-o-matic guts over to promises where appropriate (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: update to ToT Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/GardeningServer/scripts/model_unittests.js

diff --git a/Tools/GardeningServer/scripts/model_unittests.js b/Tools/GardeningServer/scripts/model_unittests.js

index e2bea969121ff8aa214d979c81d7f4f1590bc01c..e53a5ad4671c79f34a38eb5f6226d84e3f034e1b 100644

--- a/Tools/GardeningServer/scripts/model_unittests.js

+++ b/Tools/GardeningServer/scripts/model_unittests.js

@@ -128,7 +128,7 @@ asyncTest("updateRecentCommits", 2, function() {

};

simulator.runTest(function() {

- model.updateRecentCommits(function() {

+ model.updateRecentCommits().then(function() {

var recentCommits = model.state.recentCommits;

delete model.state.recentCommits;

$.each(recentCommits, function(index, commitData) {

@@ -180,7 +180,7 @@ asyncTest("commitDataListForRevisionRange", 6, function() {

};

simulator.runTest(function() {

- model.updateRecentCommits(function() {

+ model.updateRecentCommits().then(function() {

function extractBugIDs(commitData)

{

return commitData.bugID;

« no previous file with comments | « Tools/GardeningServer/scripts/model.js ('k') | Tools/GardeningServer/scripts/results.js » ('j') | no next file with comments »