Tools/GardeningServer/scripts/ui.js - Issue 173133003: Convert garden-o-matic guts over to promises where appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/GardeningServer/scripts/ui.js

Issue 173133003: Convert garden-o-matic guts over to promises where appropriate (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/GardeningServer/scripts/ui.js

diff --git a/Tools/GardeningServer/scripts/ui.js b/Tools/GardeningServer/scripts/ui.js

index bb8ab59299c29757183596204ebf3b4300bca8f9..ed5f27a210356ca90caff9c8e07ce68097b20191 100644

--- a/Tools/GardeningServer/scripts/ui.js

+++ b/Tools/GardeningServer/scripts/ui.js

@@ -334,12 +334,12 @@ ui.revisionDetails = base.extends('span', {

theSpan.appendChild(document.createTextNode(', trunk is at '));

theSpan.appendChild(base.createLinkNode(trac.changesetURL(totRevision), totRevision));

- checkout.lastBlinkRollRevision(function(revision) {

+ checkout.lastBlinkRollRevision().then(function(revision) {

theSpan.appendChild(document.createTextNode(', last roll is to '));

theSpan.appendChild(base.createLinkNode(trac.changesetURL(revision), revision));

}, function() {});

- rollbot.fetchCurrentRoll(function(roll) {

+ rollbot.fetchCurrentRoll().then(function(roll) {

theSpan.appendChild(document.createTextNode(', current autoroll '));

if (roll) {

var linkText = "" + roll.fromRevision + ":" + roll.toRevision;