Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Tools/GardeningServer/scripts/model_unittests.js

Issue 173133003: Convert garden-o-matic guts over to promises where appropriate (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Tools/GardeningServer/scripts/base.js ('K') | « Tools/GardeningServer/scripts/model.js ('k') | Tools/GardeningServer/scripts/results.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/model_unittests.js
diff --git a/Tools/GardeningServer/scripts/model_unittests.js b/Tools/GardeningServer/scripts/model_unittests.js
index e2bea969121ff8aa214d979c81d7f4f1590bc01c..e53a5ad4671c79f34a38eb5f6226d84e3f034e1b 100644
--- a/Tools/GardeningServer/scripts/model_unittests.js
+++ b/Tools/GardeningServer/scripts/model_unittests.js
@@ -128,7 +128,7 @@ asyncTest("updateRecentCommits", 2, function() {
};
simulator.runTest(function() {
- model.updateRecentCommits(function() {
+ model.updateRecentCommits().then(function() {
var recentCommits = model.state.recentCommits;
delete model.state.recentCommits;
$.each(recentCommits, function(index, commitData) {
@@ -180,7 +180,7 @@ asyncTest("commitDataListForRevisionRange", 6, function() {
};
simulator.runTest(function() {
- model.updateRecentCommits(function() {
+ model.updateRecentCommits().then(function() {
function extractBugIDs(commitData)
{
return commitData.bugID;
« Tools/GardeningServer/scripts/base.js ('K') | « Tools/GardeningServer/scripts/model.js ('k') | Tools/GardeningServer/scripts/results.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698