Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Tools/GardeningServer/scripts/builders_unittests.js

Issue 173133003: Convert garden-o-matic guts over to promises where appropriate (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Tools/GardeningServer/scripts/base.js ('K') | « Tools/GardeningServer/scripts/builders.js ('k') | Tools/GardeningServer/scripts/checkout.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/builders_unittests.js
diff --git a/Tools/GardeningServer/scripts/builders_unittests.js b/Tools/GardeningServer/scripts/builders_unittests.js
index 4185261cecf8c57b49a17ebcd0abe59d3a548602..fe5bca9c1c7b927adc0dd78f0265fbba0f3b2b29 100644
--- a/Tools/GardeningServer/scripts/builders_unittests.js
+++ b/Tools/GardeningServer/scripts/builders_unittests.js
@@ -717,7 +717,7 @@ asyncTest("buildersFailing", 3, function() {
};
simulator.runTest(function() {
- builders.buildersFailingNonLayoutTests(function(builderNameList) {
+ builders.buildersFailingNonLayoutTests().then(function(builderNameList) {
deepEqual(builderNameList, {
"WebKit Linux": [
"webkit_gpu_tests"
@@ -771,7 +771,7 @@ asyncTest("buildersFailing (run-webkit-tests crash)", 3, function() {
};
simulator.runTest(function() {
- builders.buildersFailingNonLayoutTests(function(builderNameList) {
+ builders.buildersFailingNonLayoutTests().then(function(builderNameList) {
deepEqual(builderNameList, {
"WebKit Linux": [
"webkit_tests",
@@ -827,7 +827,7 @@ asyncTest("buildersFailing (taskkill warning)", 3, function() {
};
simulator.runTest(function() {
- builders.buildersFailingNonLayoutTests(function(builderNameList) {
+ builders.buildersFailingNonLayoutTests().then(function(builderNameList) {
deepEqual(builderNameList, {});
});
}).then(function() {
« Tools/GardeningServer/scripts/base.js ('K') | « Tools/GardeningServer/scripts/builders.js ('k') | Tools/GardeningServer/scripts/checkout.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698