Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: Tools/GardeningServer/scripts/svn-log.js

Issue 173133003: Convert garden-o-matic guts over to promises where appropriate (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: update to ToT Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 98
99 trac.changesetURL = function(revision) 99 trac.changesetURL = function(revision)
100 { 100 {
101 var queryParameters = { 101 var queryParameters = {
102 view: 'rev', 102 view: 'rev',
103 revision: revision, 103 revision: revision,
104 }; 104 };
105 return config.kBlinkRevisionURL + '?' + $.param(queryParameters); 105 return config.kBlinkRevisionURL + '?' + $.param(queryParameters);
106 }; 106 };
107 107
108 trac.recentCommitData = function(path, limit, callback) 108 trac.recentCommitData = function(path, limit)
109 { 109 {
110 net.xml('http://blink.lc/blink/atom').then(function(commitData) { 110 return net.xml('http://blink.lc/blink/atom').then(function(commitData) {
111 callback(parseCommitData(commitData)); 111 return parseCommitData(commitData);
112 }); 112 });
113 }; 113 };
114 114
115 trac.commitDataForRevisionRange = function(path, startRevision, endRevision, cal lback)
116 {
117 var key = [path, startRevision, endRevision].join('\n');
118 g_cache.get(key, callback);
119 };
120
121 })(); 115 })();
OLDNEW
« no previous file with comments | « Tools/GardeningServer/scripts/rollbot_unittests.js ('k') | Tools/GardeningServer/scripts/svn-log_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698