Convert garden-o-matic guts over to promises where appropriate

Tools/GardeningServer/scripts/ui/results_unittests.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 106 matching lines @@
     "userscripts/another-test.html": {
         "Mock Builder": {
             "expected": "PASS",
             "actual": "TEXT"
         }
     }
 };
 
 test('View', 18, function() {
     var delegate = {
-        fetchResultsURLs: function(failureInfo, callback) { return; }
+        fetchResultsURLs: function(failureInfo) { return Promise.resolve(); }
     };
 
     var view = new ui.results.View(delegate);
     view.setResultsByTest(kExampleResultsByTest);
 
     view.firstResult();
     var testSelector = view.querySelector('.test-selector');
     var topPanel = testSelector.querySelector('.top-panel');
     equals(topPanel.childNodes[0], topPanel.querySelector('.active'));;
     equals($($('.builder-selector', view)[0]).tabs('option', 'selected'), 0);
@@ skipping 21 matching lines @@
     equals(topPanel.childNodes[0], topPanel.querySelector('.active'));;
     equals($($('.builder-selector', view)[0]).tabs('option', 'selected'), 1);
     equals(view.currentTestName(), 'scrollbars/custom-scrollbar-with-incomplete-style.html');
 
     ok(!testSelector.querySelector('.resize-handle'));
     equals(topPanel.style.minHeight, '');
 });
 
 test('View with more than four tests', 2, function() {
     var delegate = {
-        fetchResultsURLs: function(failureInfo, callback) { return; }
+        fetchResultsURLs: function(failureInfo) { return Promise.resolve(); }
     };
 
     var view = new ui.results.View(delegate);
     view.setResultsByTest(kExampleGreaterThanFourResultsByTest);
 
     var testSelector = view.querySelector('.test-selector');
     var topPanel = testSelector.querySelector('.top-panel');
 
     ok(testSelector.querySelector('.resize-handle'));
     equals(topPanel.style.minHeight, '100px');
 });
 
 test('View with reftests', 2, function() {
     var delegate = {
-        fetchResultsURLs: function(failureInfo, callback) { return; }
+        fetchResultsURLs: function(failureInfo) { return Promise.resolve(); }
     };
 
     var view = new ui.results.View(delegate);
     view.setResultsByTest(kExampleReftestResults);
     view.firstResult();
 
     equals($('.non-action-button', view).length, 1);
     equals($('.action', view).length, 0);
 });
 
-test('View of timeouts', 1, function() {
+asyncTest('View of timeouts', 1, function() {
+    var emptyPromise = Promise.resolve([]);
     var delegate = {
-        fetchResultsURLs: function(failureInfo, callback) { callback([]); }
+        fetchResultsURLs: function(failureInfo) { return emptyPromise; }
     };
 
     var view = new ui.results.View(delegate);
     view.setResultsByTest(kExampleResultsWithTimeoutByTest);
     view.firstResult();
-
-    equals($('.results-grid', view).html(), 'No results to display.');
+    emptyPromise.then(function() {
+        equals($('.results-grid', view).html(), 'No results to display.');
+        start();
+    });
 });
 
 })();