Convert garden-o-matic guts over to promises where appropriate

Tools/GardeningServer/scripts/ui/results.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 131 matching lines @@
         $.each(resultsURLsByTypeAndKind, function(resultType, resultsURLsByKind) {
             if ($.isEmptyObject(resultsURLsByKind))
                 return;
             if (results.kUnknownKind in resultsURLsByKind) {
                 // This is something like "crash" that isn't a comparison.
                 this.addRow(resultType, resultsURLsByKind[results.kUnknownKind]);
                 return;
             }
             this.addComparison(resultType, resultsURLsByKind);
         }.bind(this));
-
         if (!this.children.length)
             this.textContent = 'No results to display.'
     }
 });
 
 ui.results.ResultsDetails = base.extends('div', {
     init: function(delegate, failureInfo)
     {
         this.className = 'results-detail';
         this._delegate = delegate;
         this._failureInfo = failureInfo;
         this._haveShownOnce = false;
     },
     show: function() {
         if (this._haveShownOnce)
             return;
         this._haveShownOnce = true;
-        this._delegate.fetchResultsURLs(this._failureInfo, function(resultsURLs) {
+        this._delegate.fetchResultsURLs(this._failureInfo).then(function(resultsURLs) {
             var resultsGrid = new ui.results.ResultsGrid();
             resultsGrid.addResults(resultsURLs);
 
             $(this).empty().append(
                 new ui.actions.List([
                     new ui.actions.Previous(),
                     new ui.actions.Next()
                 ])).append(resultsGrid);
 
 
@@ skipping 244 matching lines @@
         var failureInfo = results.failureInfoForTestAndBuilder(this._resultsByTest, testName, builderName);
         return new ui.results.ResultsDetails(this, failureInfo);
     },
     setResultsByTest: function(resultsByTest)
     {
         $(this).empty();
         this._resultsByTest = resultsByTest;
         this._testSelector = new ui.results.TestSelector(this, resultsByTest);
         this.appendChild(this._testSelector);
     },
-    fetchResultsURLs: function(failureInfo, callback)
+    fetchResultsURLs: function(failureInfo)
     {
-        this._delegate.fetchResultsURLs(failureInfo, callback)
+        return this._delegate.fetchResultsURLs(failureInfo);
     },
     nextResult: function()
     {
         return this._testSelector.nextResult();
     },
     previousResult: function()
     {
         return this._testSelector.previousResult();
     },
     nextTest: function()
     {
         return this._testSelector.nextTest();
     },
     previousTest: function()
     {
         return this._testSelector.previousTest();
     },
     firstResult: function()
     {
         this._testSelector.firstResult()
     },
     currentTestName: function()
     {
         return this._testSelector.currentTestName()
     }
 });
 
 })();