Convert garden-o-matic guts over to promises where appropriate

Tools/GardeningServer/scripts/results_unittests.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 348 matching lines @@
                         '<Prefix>Another_Builder/22201/</Prefix>' +
                         '<Prefix>Another_Builder/22202/</Prefix>' +
                         '</ListBucketResult>');
         else {
             ok(false, 'Unexpected URL: ' + url);
             return Promise.reject('Unexpected URL: ' + url);
         }
     };
 
     simulator.runTest(function() {
-        results.regressionRangeForFailure("Mock Builder", "userscripts/another-test.html", function(oldestFailingRevision, newestPassingRevision) {
-            equals(oldestFailingRevision, 90426);
-            equals(newestPassingRevision, 90424);
-        });
-
-        results.unifyRegressionRanges(["Mock Builder", "Another Builder"], "userscripts/another-test.html", function(oldestFailingRevision, newestPassingRevision) {
-            equals(oldestFailingRevision, 90426);
-            equals(newestPassingRevision, 90425);
-        });
+            results.regressionRangeForFailure("Mock Builder", "userscripts/another-test.html")
+                .then(function(result) {
+                    var oldestFailingRevision = result[0];
+                    var newestPassingRevision = result[1];
+                    equals(oldestFailingRevision, 90426);
+                    equals(newestPassingRevision, 90424);
+                });
+            results.unifyRegressionRanges(["Mock Builder", "Another Builder"], "userscripts/another-test.html")
+                .then(function(result) {
+                    var oldestFailingRevision = result[0];
+                    var newestPassingRevision = result[1];
+                    equals(oldestFailingRevision, 90426);
+                    equals(newestPassingRevision, 90425);
+                });
     }).then(start);
 });
 
 asyncTest("walkHistory (no revision)", 3, function() {
     var simulator = new NetworkSimulator();
 
     var keyMap = {
         "Mock_Builder": {
             "11103": {
                 "tests": {
@@ skipping 21 matching lines @@
 
     simulator.xml = function(url) {
         return Promise.resolve('<a href="11101/"></a><a href="11102/"></a><a href="11103/"></a>');
     };
 
     simulator.json = function(url) {
         return Promise.resolve({});
     };
 
     simulator.runTest(function() {
-        results.regressionRangeForFailure("Mock Builder", "userscripts/another-test.html", function(oldestFailingRevision, newestPassingRevision) {
+        results.regressionRangeForFailure("Mock Builder", "userscripts/another-test.html").then(function(result) {
+            var oldestFailingRevision = result[0];
+            var newestPassingRevision = result[1];
             equals(oldestFailingRevision, 0);
             equals(newestPassingRevision, 0);
-        });
-    }).then(start);
+        }).then(start);
+    });
 });
 
 test("collectUnexpectedResults", 1, function() {
     var dictionaryOfResultNodes = {
         "foo": {
             "expected": "IMAGE",
             "actual": "IMAGE"
         },
         "bar": {
             "expected": "PASS",
@@ skipping 38 matching lines @@
             return Promise.resolve();
         else
             return Promise.reject();
     };
 
     simulator.runTest(function() {
         results.fetchResultsURLs({
             'builderName': "Mock Builder",
             'testName': "userscripts/another-test.html",
             'failureTypeList': ['IMAGE', 'CRASH'],
-        }, function(resultURLs) {
+        }).then(function(resultURLs) {
             deepEqual(resultURLs, [
                 MockResultsBaseURL + "/userscripts/another-test-crash-log.txt"
             ]);
         });
         results.fetchResultsURLs({
             'builderName': "Mock Builder",
             'testName': "userscripts/another-test.html",
             'failureTypeList': ['TIMEOUT'],
-        }, function(resultURLs) {
+        }).then(function(resultURLs) {
             deepEqual(resultURLs, []);
         });
         results.fetchResultsURLs({
             'builderName': "Mock Builder",
             'testName': "userscripts/taco.html",
             'failureTypeList': ['IMAGE', 'IMAGE+TEXT'],
-        }, function(resultURLs) {
+        }).then(function(resultURLs) {
             deepEqual(resultURLs, [
                 MockResultsBaseURL + "/userscripts/taco-expected.png",
                 MockResultsBaseURL + "/userscripts/taco-actual.png",
                 MockResultsBaseURL + "/userscripts/taco-diff.png",
                 MockResultsBaseURL + "/userscripts/taco-expected.txt",
                 MockResultsBaseURL + "/userscripts/taco-actual.txt",
                 MockResultsBaseURL + "/userscripts/taco-diff.txt",
             ]);
         });
     }).then(function() {
@@ skipping 17 matching lines @@
     var simulator = new NetworkSimulator();
 
     var probedURLs = [];
     simulator.jsonp = function(url)
     {
         probedURLs.push(url);
         return Promise.resolve(base.endsWith(url, 'results/layout-test-results/failing_results.json'));
     };
 
     simulator.runTest(function() {
-        results.fetchResultsByBuilder(['MockBuilder1', 'MockBuilder2'], function(resultsByBuilder) {
+        results.fetchResultsByBuilder(['MockBuilder1', 'MockBuilder2']).then(function(resultsByBuilder) {
             deepEqual(resultsByBuilder, {
                 "MockBuilder1": true,
                 "MockBuilder2": true,
             });
         });
     }).then(start);
 
     deepEqual(probedURLs, [
         MockResultsBaseURL.replace('Mock_Builder', 'MockBuilder1') + "/failing_results.json",
         MockResultsBaseURL.replace('Mock_Builder', 'MockBuilder2') + "/failing_results.json"
     ]);
 
 });
 
 })();