Convert garden-o-matic guts over to promises where appropriate

Tools/GardeningServer/scripts/model_unittests.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 110 matching lines @@
     var simulator = new NetworkSimulator();
 
     simulator.xml = function(url)
     {
         var parser = new DOMParser();
         var responseDOM = parser.parseFromString(kExampleCommitDataXML, "application/xml");
         return Promise.resolve(responseDOM);
     };
 
     simulator.runTest(function() {
-        model.updateRecentCommits(function() {
+        model.updateRecentCommits().then(function() {
             var recentCommits = model.state.recentCommits;
             delete model.state.recentCommits;
             $.each(recentCommits, function(index, commitData) {
                 delete commitData.message;
             });
             deepEqual(recentCommits, [{
                 "revision": 3,
                 "title": "This matches Gecko's behavior for these types of properties.",
                 "time": "2013-09-30T20:22:01Z",
                 "summary": "This matches Gecko's behavior for these types of properties.",
@@ skipping 31 matching lines @@
     var simulator = new NetworkSimulator();
 
     simulator.xml = function(url)
     {
         var parser = new DOMParser();
         var responseDOM = parser.parseFromString(kExampleCommitDataXML, "application/xml");
         return Promise.resolve(responseDOM);
     };
 
     simulator.runTest(function() {
-        model.updateRecentCommits(function() {
+        model.updateRecentCommits().then(function() {
             function extractBugIDs(commitData)
             {
                 return commitData.bugID;
             }
 
             deepEqual(model.commitDataListForRevisionRange(3, 3).map(extractBugIDs), [13]);
             deepEqual(model.commitDataListForRevisionRange(1, 3).map(extractBugIDs), [11, 12, 13]);
             deepEqual(model.commitDataListForRevisionRange(0, 1).map(extractBugIDs), [11]);
             deepEqual(model.commitDataListForRevisionRange(0, 4).map(extractBugIDs), [11, 12, 13]);
             deepEqual(model.commitDataListForRevisionRange(4, 0).map(extractBugIDs), []);
@@ skipping 39 matching lines @@
         'Mr. Beasley': { },
         'Mr Dixon': {blink_revision: '2'},
         'Mr. Sabatini': {blink_revision: '4'},
         'Bob': {blink_revision: '6'}
     };
     equals(model.latestRevisionWithNoBuildersInFlight(), 2);
     model.state.resultsByBuilder = unmock;
 });
 
 })();