Convert garden-o-matic guts over to promises where appropriate

Tools/GardeningServer/scripts/controllers.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 276 matching lines @@
     {
         failure.pinToCommitData(commitData);
         $('.action', failure).each(function() {
             // FIXME: This isn't the right way of finding and disabling this action.
             if (this.textContent == 'Blame')
                 this.disabled = true;
         });
     },
     onRollout: function(revision, testNameList)
     {
-        checkout.rollout(revision, ui.rolloutReasonForTestNameList(testNameList), $.noop, function() {
+        checkout.rollout(revision, ui.rolloutReasonForTestNameList(testNameList)).then($.noop, function() {
             // FIXME: We should have a better error UI.
             alert(kCheckoutUnavailableMessage);
         });
     }
 });
 
 controllers.Failures = base.extends(FailureStreamController, {
     _resultsFilter: results.expectedFailuresByTest,
 
     _keyFor: function(failureAnalysis)
@@ skipping 30 matching lines @@
             this._notification = new ui.notifications.BuildersFailing(this._message);
             this._view.add(this._notification);
         }
         // FIXME: We should provide regression ranges for the failing builders.
         // This doesn't seem to happen often enough to worry too much about that, however.
         this._notification.setFailingBuilders(failuresList);
     }
 });
 
 })();