Convert garden-o-matic guts over to promises where appropriate

Tools/GardeningServer/scripts/checkout.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 11 matching lines @@
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 var checkout = checkout || {};
 
 (function() {
 
 var g_haveSeenCheckoutAvailable = false;
 
-function callIfCheckoutAvailable(callback, checkoutUnavailable)
+function checkoutAvailable()
 {
     if (g_haveSeenCheckoutAvailable) {
-        callback();
-        return;
+        return Promise.resolve();
     }
-    checkout.isAvailable(function(isAvailable) {
+
+    return checkout.isAvailable().then(function(isAvailable) {
         if (isAvailable) {
             g_haveSeenCheckoutAvailable = true;
-            callback();
             return;
         }
-        if (checkoutUnavailable)
-            checkoutUnavailable();
     });
-}
+};
 
-checkout.isAvailable = function(callback)
+checkout.isAvailable = function()
 {
-    net.ajax({
+    return net.ajax({
         url: '/ping',
     }).then(function() { return true; },
-            function() { return false; })
-    .then(callback);
+            function() { return false; });
 };
 
-checkout.lastBlinkRollRevision = function(callback, checkoutUnavailable)
+checkout.lastBlinkRollRevision = function()
 {
-    callIfCheckoutAvailable(function() {
-        net.get('/lastroll').then(callback);
-    }, checkoutUnavailable);
-}
+    return checkoutAvailable().then(function() {
+        return net.get('/lastroll');
+    });
+};
 
-checkout.rollout = function(revision, reason, callback, checkoutUnavailable)
+checkout.rollout = function(revision, reason)
 {
-    callIfCheckoutAvailable(function() {
-        net.post('/rollout?' + $.param({
+    return checkoutAvailable().then(function() {
+        return net.post('/rollout?' + $.param({
             'revision': revision,
             'reason': reason
-        })).then(callback);
-    }, checkoutUnavailable);
+        }));
+    });
 };
 
-checkout.rebaseline = function(failureInfoList, callback, progressCallback, checkoutUnavailable, debugBotsCallback)
+checkout.rebaseline = function(failureInfoList, progressCallback, debugBotsCallback)
 {
-    callIfCheckoutAvailable(function() {
+    return checkoutAvailable().then(function() {
         var tests = {};
         for (var i = 0; i < failureInfoList.length; i++) {
             var failureInfo = failureInfoList[i];
             if (failureInfo.builderName.indexOf('dbg') != -1) {
                 debugBotsCallback(failureInfo);
                 continue;
             }
             tests[failureInfo.testName] = tests[failureInfo.testName] || {};
             tests[failureInfo.testName][failureInfo.builderName] =
                 base.uniquifyArray(base.flattenArray(failureInfo.failureTypeList.map(results.failureTypeToExtensionList)));
         }
-        net.post('/rebaselineall', JSON.stringify(tests)).then(callback);
-    }, checkoutUnavailable);
+        return net.post('/rebaselineall', JSON.stringify(tests));
+    });
 };
 
 })();