Convert garden-o-matic guts over to promises where appropriate

Tools/GardeningServer/scripts/builders.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 52 matching lines @@
 
     for (var i = individualBuilderStatus.cachedBuilds.length - 1; i >= 0; --i) {
         var buildNumber = individualBuilderStatus.cachedBuilds[i];
         if (individualBuilderStatus.currentBuilds.indexOf(buildNumber) == -1)
             return buildNumber;
     }
 
     return null;
 }
 
-var g_buildInfoCache = new base.AsynchronousCache(function(key, callback) {
+var g_buildInfoCache = new base.AsynchronousCache(function(key) {
     var explodedKey = key.split('\n');
-    net.json(urlForBuildInfo(explodedKey[0], explodedKey[1])).then(callback);
+    return net.json(urlForBuildInfo(explodedKey[0], explodedKey[1]));
 });
 
 builders.clearBuildInfoCache = function()
 {
     g_buildInfoCache.clear();
 };
 
-function fetchMostRecentBuildInfoByBuilder(callback)
+function fetchMostRecentBuildInfoByBuilder()
 {
-    net.json(config.buildConsoleURL + '/json/builders').then(function(builderStatus) {
-        var buildInfoByBuilder = {};
+    var buildInfoByBuilder = {};
+    var requestPromises = [];
+    return net.json(config.buildConsoleURL + '/json/builders').then(function(builderStatus) {
         var builderNames = Object.keys(builderStatus);
-        var requestTracker = new base.RequestTracker(builderNames.length, callback, [buildInfoByBuilder]);
         builderNames.forEach(function(builderName) {
-            if (!config.builderApplies(builderName)) {
-                requestTracker.requestComplete();
+            if (!config.builderApplies(builderName))
                 return;
-            }
 
             var buildNumber = mostRecentCompletedBuildNumber(builderStatus[builderName]);
-            if (!buildNumber) {
-                buildInfoByBuilder[builderName] = null;
-                requestTracker.requestComplete();
+            if (!buildNumber)
                 return;
-            }
 
-            g_buildInfoCache.get(builderName + '\n' + buildNumber, function(buildInfo) {
-                buildInfoByBuilder[builderName] = buildInfo;
-                requestTracker.requestComplete();
-            });
+            requestPromises.push(g_buildInfoCache.get(builderName + '\n' + buildNumber)
+                                 .then(function(buildInfo) {
+                                     buildInfoByBuilder[builderName] = buildInfo;
+                                 }));
+        });
+
+        return Promise.all(requestPromises).then(function() {
+            return buildInfoByBuilder;
         });
     });
 }
 
-builders.buildersFailingNonLayoutTests = function(callback)
+builders.buildersFailingNonLayoutTests = function()
 {
-    fetchMostRecentBuildInfoByBuilder(function(buildInfoByBuilder) {
+    return fetchMostRecentBuildInfoByBuilder().then(function(buildInfoByBuilder) {
         var failureList = {};
         $.each(buildInfoByBuilder, function(builderName, buildInfo) {
             if (!buildInfo)
                 return;
             var failures = failingSteps(buildInfo);
             if (failures.length)
                 failureList[builderName] = failures.map(function(failure) { return failure.name; });
         });
-        callback(failureList);
+        return failureList;
     });
 };
 
-builders.mostRecentBuildForBuilder = function(builderName, callback) {
-    net.json(config.buildConsoleURL + '/json/builders/' + builderName).then(function(builderStatus) {
+builders.mostRecentBuildForBuilder = function(builderName) {
+    return net.json(config.buildConsoleURL + '/json/builders/' + builderName).then(function(builderStatus) {
         var cachedBuilds = builderStatus.cachedBuilds;
         var mostRecentBuild = Math.max.apply(Math, cachedBuilds);
-        callback(mostRecentBuild);
+        return mostRecentBuild;
     });
 };
 
 })();