Convert garden-o-matic guts over to promises where appropriate

Tools/GardeningServer/scripts/base_unittests.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 62 matching lines @@
 });
 
 test("flattenArray", 5, function() {
     deepEqual(base.flattenArray([]), []);
     deepEqual(base.flattenArray([["a"]]), ["a"]);
     deepEqual(base.flattenArray([["a"], ["b"]]), ["a", "b"]);
     deepEqual(base.flattenArray([["a"], ["b", "c"]]), ["a", "b", "c"]);
     deepEqual(base.flattenArray([["a"], [], ["b"]]), ["a", "b"]);
 });
 
-test("callInParallel", 4, function() {
-    var expectedCall = [true, true, true];
-    var expectCompletionCallback = true;
-
-    base.callInParallel([
-        function(callback) {
-            ok(expectedCall[0]);
-            expectedCall[0] = false;
-            callback();
-        },
-        function(callback) {
-            ok(expectedCall[1]);
-            expectedCall[1] = false;
-            callback();
-        },
-        function(callback) {
-            ok(expectedCall[2]);
-            expectedCall[2] = false;
-            callback();
-        },
-    ], function() {
-        ok(expectCompletionCallback);
-        expectCompletionCallback = false;
-    })
-});
-
-test("RequestTracker", 5, function() {
-    var ready = false;
-    var tracker = new base.RequestTracker(1, function() {
-        ok(ready);
-    });
-    ready = true;
-    tracker.requestComplete();
-    ready = false;
-
-    tracker = new base.RequestTracker(2, function(parameter) {
-        ok(ready);
-        equals(parameter, 'argument');
-    }, ['argument']);
-    tracker.requestComplete();
-    ready = true;
-    tracker.requestComplete();
-    ready = false;
-
-    tracker = new base.RequestTracker(0, function() {
-        ok(true);
-    });
-    tracker.requestComplete();
-
-    tracker = new base.RequestTracker(0);
-    tracker.requestComplete();
-    // Should not barf.
-    ok(true);
-});
-
 test("filterDictionary", 3, function() {
     var dictionary = {
         'foo': 43,
         'bar': 11
     };
     deepEqual(base.filterDictionary(dictionary, function() { return true; }), {
         "foo": 43,
         "bar": 11
     });
     deepEqual(base.filterDictionary(dictionary, function() { return false; }), { });
@@ skipping 259 matching lines @@
 test("parseJSONP", 6, function() {
     deepEqual(base.parseJSONP(""), {});
     deepEqual(base.parseJSONP('p({"key": "value"})'), {"key": "value"});
     deepEqual(base.parseJSONP('ADD_RESULTS({"dummy":"data"});'), {"dummy":"data"});
     deepEqual(base.parseJSONP('{"dummy":"data"}'), {"dummy":"data"});
     deepEqual(base.parseJSONP('ADD_RESULTS({"builder(1)":"data"});'), {"builder(1)":"data"});
     deepEqual(base.parseJSONP('{"builder(1)":"data"}'), {"builder(1)":"data"});
 });
 
 })();