Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: src/crankshaft/x87/lithium-x87.cc

Issue 1731303002: [crankshaft] Remove useless HCallFunction instruction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/x87/lithium-x87.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/x87/lithium-x87.h" 5 #include "src/crankshaft/x87/lithium-x87.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #if V8_TARGET_ARCH_X87 9 #if V8_TARGET_ARCH_X87
10 10
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 271
272 272
273 void LInnerAllocatedObject::PrintDataTo(StringStream* stream) { 273 void LInnerAllocatedObject::PrintDataTo(StringStream* stream) {
274 stream->Add(" = "); 274 stream->Add(" = ");
275 base_object()->PrintTo(stream); 275 base_object()->PrintTo(stream);
276 stream->Add(" + "); 276 stream->Add(" + ");
277 offset()->PrintTo(stream); 277 offset()->PrintTo(stream);
278 } 278 }
279 279
280 280
281 void LCallFunction::PrintDataTo(StringStream* stream) {
282 context()->PrintTo(stream);
283 stream->Add(" ");
284 function()->PrintTo(stream);
285 if (hydrogen()->HasVectorAndSlot()) {
286 stream->Add(" (type-feedback-vector ");
287 temp_vector()->PrintTo(stream);
288 stream->Add(" ");
289 temp_slot()->PrintTo(stream);
290 stream->Add(")");
291 }
292 }
293
294
295 void LCallJSFunction::PrintDataTo(StringStream* stream) { 281 void LCallJSFunction::PrintDataTo(StringStream* stream) {
296 stream->Add("= "); 282 stream->Add("= ");
297 function()->PrintTo(stream); 283 function()->PrintTo(stream);
298 stream->Add("#%d / ", arity()); 284 stream->Add("#%d / ", arity());
299 } 285 }
300 286
301 287
302 void LCallWithDescriptor::PrintDataTo(StringStream* stream) { 288 void LCallWithDescriptor::PrintDataTo(StringStream* stream) {
303 for (int i = 0; i < InputCount(); i++) { 289 for (int i = 0; i < InputCount(); i++) {
304 InputAt(i)->PrintTo(stream); 290 InputAt(i)->PrintTo(stream);
(...skipping 951 matching lines...) Expand 10 before | Expand all | Expand 10 after
1256 1242
1257 1243
1258 LInstruction* LChunkBuilder::DoCallNewArray(HCallNewArray* instr) { 1244 LInstruction* LChunkBuilder::DoCallNewArray(HCallNewArray* instr) {
1259 LOperand* context = UseFixed(instr->context(), esi); 1245 LOperand* context = UseFixed(instr->context(), esi);
1260 LOperand* constructor = UseFixed(instr->constructor(), edi); 1246 LOperand* constructor = UseFixed(instr->constructor(), edi);
1261 LCallNewArray* result = new(zone()) LCallNewArray(context, constructor); 1247 LCallNewArray* result = new(zone()) LCallNewArray(context, constructor);
1262 return MarkAsCall(DefineFixed(result, eax), instr); 1248 return MarkAsCall(DefineFixed(result, eax), instr);
1263 } 1249 }
1264 1250
1265 1251
1266 LInstruction* LChunkBuilder::DoCallFunction(HCallFunction* instr) {
1267 LOperand* context = UseFixed(instr->context(), esi);
1268 LOperand* function = UseFixed(instr->function(), edi);
1269 LOperand* slot = NULL;
1270 LOperand* vector = NULL;
1271 if (instr->HasVectorAndSlot()) {
1272 slot = FixedTemp(edx);
1273 vector = FixedTemp(ebx);
1274 }
1275
1276 LCallFunction* call =
1277 new (zone()) LCallFunction(context, function, slot, vector);
1278 return MarkAsCall(DefineFixed(call, eax), instr);
1279 }
1280
1281
1282 LInstruction* LChunkBuilder::DoCallRuntime(HCallRuntime* instr) { 1252 LInstruction* LChunkBuilder::DoCallRuntime(HCallRuntime* instr) {
1283 LOperand* context = UseFixed(instr->context(), esi); 1253 LOperand* context = UseFixed(instr->context(), esi);
1284 return MarkAsCall(DefineFixed(new(zone()) LCallRuntime(context), eax), instr); 1254 return MarkAsCall(DefineFixed(new(zone()) LCallRuntime(context), eax), instr);
1285 } 1255 }
1286 1256
1287 1257
1288 LInstruction* LChunkBuilder::DoRor(HRor* instr) { 1258 LInstruction* LChunkBuilder::DoRor(HRor* instr) {
1289 return DoShift(Token::ROR, instr); 1259 return DoShift(Token::ROR, instr);
1290 } 1260 }
1291 1261
(...skipping 1377 matching lines...) Expand 10 before | Expand all | Expand 10 after
2669 LInstruction* LChunkBuilder::DoStoreFrameContext(HStoreFrameContext* instr) { 2639 LInstruction* LChunkBuilder::DoStoreFrameContext(HStoreFrameContext* instr) {
2670 LOperand* context = UseRegisterAtStart(instr->context()); 2640 LOperand* context = UseRegisterAtStart(instr->context());
2671 return new(zone()) LStoreFrameContext(context); 2641 return new(zone()) LStoreFrameContext(context);
2672 } 2642 }
2673 2643
2674 2644
2675 } // namespace internal 2645 } // namespace internal
2676 } // namespace v8 2646 } // namespace v8
2677 2647
2678 #endif // V8_TARGET_ARCH_X87 2648 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/crankshaft/x87/lithium-x87.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698