Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 1731253003: Revert of [Interpreter] Implements calls through CallICStub in the interpreter. (Closed)

Created:
4 years, 10 months ago by mythria
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, oth, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Implements calls through CallICStub in the interpreter. (patchset #15 id:270001 of https://codereview.chromium.org/1688283003/ ) Reason for revert: It is not a good idea to call CallICStub from the builtin. It might be sensitive to the frame structure. Constructing a internal frame might cause problems. It is much better to inline the code related to the type feedback vector into the builtin. Original issue's description: > [Interpreter] Implements calls through CallICStub in the interpreter. > > Calls are implemented through CallICStub to collect type feedback. Adds > a new builtin called InterpreterPushArgsAndCallIC that pushes the > arguments onto stack and calls CallICStub. > > Also adds two new bytecodes CallIC and CallICWide to indicate calls have to > go through CallICStub. > > MIPS port contributed by balazs.kilvady. > > BUG=v8:4280, v8:4680 > LOG=N > > Committed: https://crrev.com/20362a2214c11a0f2ea5141b6a79e09458939cec > Cr-Commit-Position: refs/heads/master@{#34244} TBR=rmcilroy@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280, v8:4680 Committed: https://crrev.com/eb358178f8a1f4cb06f8549ea2dccf4c3915398e Cr-Commit-Position: refs/heads/master@{#34252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -1149 lines) Patch
M src/arm/builtins-arm.cc View 3 chunks +3 lines, -52 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 7 chunks +8 lines, -28 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 3 chunks +17 lines, -64 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 8 chunks +8 lines, -28 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/builtins.h View 3 chunks +0 lines, -13 lines 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/code-factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/code-factory.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/compiler/bytecode-graph-builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 3 chunks +7 lines, -38 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 5 chunks +26 lines, -81 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 8 chunks +8 lines, -30 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ic/ic-state.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +1 line, -7 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 2 chunks +3 lines, -14 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 4 chunks +6 lines, -41 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +5 lines, -11 lines 0 comments Download
M src/interpreter/bytecodes.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/interpreter/interpreter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +1 line, -52 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/mips/builtins-mips.cc View 3 chunks +13 lines, -66 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 7 chunks +18 lines, -32 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 3 chunks +12 lines, -66 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 6 chunks +24 lines, -38 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/x64/builtins-x64.cc View 4 chunks +2 lines, -44 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 8 chunks +9 lines, -31 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M test/cctest/cctest.status View 2 chunks +9 lines, -12 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 29 chunks +76 lines, -183 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 7 chunks +16 lines, -54 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -6 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mythria
Created Revert of [Interpreter] Implements calls through CallICStub in the interpreter.
4 years, 10 months ago (2016-02-24 15:14:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731253003/1
4 years, 10 months ago (2016-02-24 15:14:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 15:15:08 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 15:16:29 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb358178f8a1f4cb06f8549ea2dccf4c3915398e
Cr-Commit-Position: refs/heads/master@{#34252}

Powered by Google App Engine
This is Rietveld 408576698