webkitTransitionEnd is not triggered if property chane happens too fast

webkitTransitionEnd is not triggered if property change happens too fast

In certain scenario SyncSetupOverlay shows and closes very fast. In this
case according to comment for ensureTransitionEndEvent in utils.js
webkitTransitionEnd doesn't fire.

Call ensureTransitionEndEvent to make sure event fires.

R=dbeam@chromium.org
BUG=343121
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252256

[pavely, 2014-02-19 23:08:41]

https://codereview.chromium.org/173123002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.js (right):

https://codereview.chromium.org/173123002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.js:891: (e.propertyName != null &&
e.propertyName != 'opacity'))
ensureTransitionEndEvent will dispatch event without propertyName, thus check
for null.

[Dan Beam, 2014-02-19 23:28:42]

lgtm w/nit (please address)

https://codereview.chromium.org/173123002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.js (right):

https://codereview.chromium.org/173123002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.js:891: (e.propertyName != null &&
e.propertyName != 'opacity'))
nit: remove the null check

  var propName = e.propertyName;
  if (e.target != e.currentTarget || (propName && propName != 'opacity'))
    return;

[pavely, 2014-02-19 23:43:25]

https://codereview.chromium.org/173123002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.js (right):

https://codereview.chromium.org/173123002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.js:891: (e.propertyName != null &&
e.propertyName != 'opacity'))
On 2014/02/19 23:28:42, Dan Beam wrote:
> nit: remove the null check
> 
>   var propName = e.propertyName;
>   if (e.target != e.currentTarget || (propName && propName != 'opacity'))
>     return;

Done.

[pavely, 2014-02-19 23:43:31]

The CQ bit was checked by pavely@chromium.org

[Dan Beam, 2014-02-20 00:29:29]

https://codereview.chromium.org/173123002/diff/2/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.js (right):

https://codereview.chromium.org/173123002/diff/2/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.js:893: return;
slgtm, but next time use curlies, e.g.

  if (e.target != e.currentTarget ||
      (propName && propName != 'opacity')) {
    return;
  }

if the conditional is more than 1 line

[pavely, 2014-02-20 00:30:28]

The CQ bit was unchecked by pavely@chromium.org

[pavely, 2014-02-20 00:32:58]

https://codereview.chromium.org/173123002/diff/2/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.js (right):

https://codereview.chromium.org/173123002/diff/2/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.js:893: return;
On 2014/02/20 00:29:29, Dan Beam wrote:
> slgtm, but next time use curlies, e.g.
> 
>   if (e.target != e.currentTarget ||
>       (propName && propName != 'opacity')) {
>     return;
>   }
> 
> if the conditional is more than 1 line

Done.

[pavely, 2014-02-20 00:33:02]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2014-02-20 01:21:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavely@chromium.org/173123002/2

[commit-bot: I haz the power, 2014-02-20 01:21:43]

Failed to trigger a try job on win_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2014-02-20 01:43:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavely@chromium.org/173123002/120001

[commit-bot: I haz the power, 2014-02-20 05:13:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavely@chromium.org/173123002/120001

[commit-bot: I haz the power, 2014-02-20 09:09:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavely@chromium.org/173123002/120001

[commit-bot: I haz the power, 2014-02-20 12:30:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavely@chromium.org/173123002/120001

[commit-bot: I haz the power, 2014-02-20 16:08:22]

Change committed as 252256