sdk/lib/_internal/pub/lib/src/version.dart - Issue 173113004: Improve the "pub lish" warnings about dependency constraints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/version.dart

Issue 173113004: Improve the "pub lish" warnings about dependency constraints. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/validator/dependency.dart ('k') | sdk/lib/_internal/pub/test/validator/dependency_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/version.dart

diff --git a/sdk/lib/_internal/pub/lib/src/version.dart b/sdk/lib/_internal/pub/lib/src/version.dart

index 1e92a3bda10a807e9ab615d13a66865e273b1f02..7577f9fe62524fc8c343e34b17a7aa840e0565dd 100644

--- a/sdk/lib/_internal/pub/lib/src/version.dart

+++ b/sdk/lib/_internal/pub/lib/src/version.dart

@@ -449,7 +449,7 @@ class VersionRange implements VersionConstraint {

bool get isEmpty => false;

- bool get isAny => !includeMin && !includeMax;

+ bool get isAny => min == null && max == null;

/// Tests if [other] matches falls within this version range.

bool allows(Version other) {