runtime/vm/intermediate_language_ia32.cc - Issue 17311002: Fix crash in OSR with --optimization-counter-threshold=-1: do not check for OSR if the optimizaiton…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 17311002: Fix crash in OSR with --optimization-counter-threshold=-1: do not check for OSR if the optimizaiton… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_ia32.cc

===================================================================

--- runtime/vm/intermediate_language_ia32.cc (revision 24103)

+++ runtime/vm/intermediate_language_ia32.cc (working copy)

@@ -2147,7 +2147,8 @@

__ cmpl(ESP,

Address::Absolute(Isolate::Current()->stack_limit_address()));

__ j(BELOW_EQUAL, slow_path->entry_label());

- if (FLAG_use_osr && !compiler->is_optimizing() && in_loop()) {

+ if (FLAG_use_osr && compiler->CanOptimizeFunction() &&

+ !compiler->is_optimizing() && in_loop()) {

siva 2013/06/17 21:31:40 Would it make sense to have a CanOSRFunction() hel

srdjan 2013/06/17 21:46:14 Done

// In unoptimized code check the usage counter to trigger OSR at loop

// stack checks.

__ LoadObject(EDI, compiler->parsed_function().function());

« no previous file with comments | « no previous file | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »