Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 173109: Enabled mono playback support for Linux. (Closed)

Created:
11 years, 4 months ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
Reviewers:
awong
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enabled mono playback support for Linux. BUG=19788 TEST=try playing any mono audio source, should just work!

Patch Set 1 #

Total comments: 4

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M media/audio/linux/alsa_output.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M media/audio/linux/alsa_output_unittest.cc View 1 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scherkus (not reviewing)
hooray!
11 years, 4 months ago (2009-08-20 02:29:24 UTC) #1
awong
LGTM Yay! 2 small fixes. http://codereview.chromium.org/173109/diff/1/3 File media/audio/linux/alsa_output_unittest.cc (right): http://codereview.chromium.org/173109/diff/1/3#newcode114 Line 114: kTestChannels - 1, ...
11 years, 4 months ago (2009-08-20 18:33:29 UTC) #2
scherkus (not reviewing)
11 years, 4 months ago (2009-08-20 18:46:09 UTC) #3
http://codereview.chromium.org/173109/diff/1/3
File media/audio/linux/alsa_output_unittest.cc (right):

http://codereview.chromium.org/173109/diff/1/3#newcode114
Line 114: kTestChannels - 1,
On 2009/08/20 18:33:29, awong wrote:
> Hmm..maybe use "1" and add a comment like " // Channels.
> 

Done.

http://codereview.chromium.org/173109/diff/1/3#newcode122
Line 122: // Only supports 2 channel.
On 2009/08/20 18:33:29, awong wrote:
> This comment should be changed, and probably do "3" instead of kTestChannels
as
> well.

Done.

Powered by Google App Engine
This is Rietveld 408576698