Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1731073002: Relax timeout for starting a service worker from 10 sec to 1 minute. (Closed)

Created:
4 years, 10 months ago by falken
Modified:
4 years, 10 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relax timeout for starting a service worker from 10 sec to 1 minute. M48 (Stable) has a timeout of 5 minutes. M49 (Beta) tried setting that to 10 seconds. Now we're seeing 0.5-1% of attempts time out on Beta as opposed to 0.02% on Stable, and the self-disabling mechanism on Dev/Canary is kicking in very often. This patch loosens the timeout to a more conservative 1 minute. BUG=559001 Committed: https://crrev.com/f32a8b4b4bfdb14d81691b3b46e2f63869410b66 Cr-Commit-Position: refs/heads/master@{#377250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M content/browser/service_worker/service_worker_version.cc View 3 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
falken
4 years, 10 months ago (2016-02-24 07:16:26 UTC) #2
horo
lgtm
4 years, 10 months ago (2016-02-24 07:44:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731073002/1
4 years, 10 months ago (2016-02-24 07:49:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 09:26:44 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 09:27:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f32a8b4b4bfdb14d81691b3b46e2f63869410b66
Cr-Commit-Position: refs/heads/master@{#377250}

Powered by Google App Engine
This is Rietveld 408576698