Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 1731023003: - Include a random number in the full snapshot filename as some of the tests (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code-review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/map_literal_oom_test.dart ('k') | tools/testing/dart/test_configurations.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 931a53d79466251cfd0c946365e968f68e334962..11730dd17531aed30bfd23d73173eab7b8ec0fc4 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -405,35 +405,37 @@ class Dart2AppSnapshotCompilerConfiguration extends CompilerConfiguration {
CommandBuilder commandBuilder,
List arguments,
Map<String, String> environmentOverrides) {
+ String outputName = computeOutputName(tempDir);
return new CommandArtifact(
<Command>[
this.computeCompilationCommand(
- tempDir,
+ outputName,
buildDir,
CommandBuilder.instance,
arguments,
environmentOverrides)],
- computeOutputName(tempDir),
+ outputName,
'application/dart-snapshot');
}
String computeOutputName(String tempDir) {
- return '$tempDir/test.snapshot';
+ var randName = TestUtils.getRandomNumber().toString();
+ return '$tempDir/test.$randName';
}
CompilationCommand computeCompilationCommand(
- String tempDir,
+ String outputName,
String buildDir,
CommandBuilder commandBuilder,
List arguments,
Map<String, String> environmentOverrides) {
var exec = "$buildDir/dart_no_snapshot";
var args = new List();
- args.add("--full-snapshot-after-run=${computeOutputName(tempDir)}");
+ args.add("--full-snapshot-after-run=$outputName");
args.addAll(arguments);
return commandBuilder.getCompilationCommand(
- 'dart2snapshot', computeOutputName(tempDir), !useSdk,
+ 'dart2snapshot', outputName, !useSdk,
bootstrapDependencies(buildDir),
exec, args, environmentOverrides);
}
« no previous file with comments | « tests/standalone/map_literal_oom_test.dart ('k') | tools/testing/dart/test_configurations.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698